Date: Fri, 22 Nov 2013 15:17:27 +0200 From: Peter Pentchev <roam@ringlet.net> To: Dominic Fandrey <kamikaze@bsdforen.de> Cc: FreeBSD Ports <ports@freebsd.org>, Kimmo Paasiala <kpaasial@gmail.com>, Eitan Adler <lists@eitanadler.com> Subject: Re: DESTDIR support broken? Message-ID: <20131122131727.GB7437@straylight.m.ringlet.net> In-Reply-To: <528F55E4.3040602@bsdforen.de> References: <52850FBA.9010308@bsdforen.de> <CAF6rxgnALxXkxLMdGkOwDwpXArCg4XMUYUEMAzU=dZS-3CGS6Q@mail.gmail.com> <5289CA5E.3010103@bsdforen.de> <CA%2B7WWSc4SRHBg6mqLOV_AHCeqZgoCzHNtqQ2W6%2BLAsSnB8i8hg@mail.gmail.com> <528BA37E.4030308@bsdforen.de> <528F55E4.3040602@bsdforen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 22, 2013 at 02:02:28PM +0100, Dominic Fandrey wrote: > On 19/11/2013 18:44, Dominic Fandrey wrote: > > On 18/11/2013 20:28, Kimmo Paasiala wrote: > >> On Mon, Nov 18, 2013 at 10:05 AM, Dominic Fandrey <kamikaze@bsdforen.d= e> wrote: > >>> On 18/11/2013 04:10, Eitan Adler wrote: > >>>> On Thu, Nov 14, 2013 at 1:00 PM, Dominic Fandrey <kamikaze@bsdforen.= de> wrote: > >>>>> # make DESTDIR=3D/root/tmpdest install > >>>>> =3D=3D=3D> Creating some important subdirectories > >>>> > >>>> Are you sure you don't mean "make PREFIX=3D/root/tmpdest/" ? > >>> > >>> Yes. > >>> > >>> -- > >> > >> I would expect DESTDIR=3D/some/path just work for any port. Last commit > >> to bsd.destdir was over a year ago so either it has been broken for a > >> long time or some other more recent commit has broken it. > >=20 > > /root/tmpdest is a complete FreeBSD chroot (I did a > > "make installworld distribution DESTDIR=3D/root/tmpdest" right beforeha= nd). > >=20 > > I tried several ports, they all exhibit the same failure. >=20 > The issue is that BSD make (in stable/10) passes "set -e" to the shell > by default. >=20 > I submitted the details and a fix: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D184170 Hmm, even if this is so, I wonder if there would not be another funny problem later: for ports that actually use staging, bsd.stage.mk tries to pass a DESTDIR of its own to upstream's build system, so the DESTDIR specified on the make(1) command line might not be passed to upstream's build system at all. So bsd.destdir.mk might do its thing, but then bsd.stage.mk would override the DESTDIR setting during the actual build and installation of the upstream sources, so I wonder if anything at all would be installed into the chroot. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org p.penchev@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 If this sentence were in Chinese, it would say something else. --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBCAAGBQJSj1liAAoJEGUe77AlJ98TZFAQAK6R9R9i5mcNN8GdPfSEyGuL nWhuxBmUR1wNqY+3glytk5LKLWfxUBz48VVqK86kd5rorYBqR8/d1lp0itGkkmDj ejC3T6CGRs8qhSuO1AIa/pehExWV/59Wzt5axwuU4FbYJW7SZK/cxtBTRqh8R8yv J9ROPCrGawpB/i5LwaiwlMDK0pcwvh0bS/Z4bUvDdMfwY7FFlgxt9Lz6BY9vnvdK QrShnN7/WQE1jIr4ys6omy2RLp1hnBbyiKp2TQIFwOSonJChvG7f5cdswZ7O03oo DDRZOHwt5pFPkVvAfBtYeRqH2iDULYC4jIVRoHowP+Xpmq3rf8eQlhBteCI4hKU/ BcEO62IKJfKYNgq5IyTuMeS+LBak7oGwTJm3a1/c5DXMESegyMXjBNNeZ/hs3uHI HoMXoF439CcV8rA2+jTq2pYMzXvsQ6lRp04C2duxc4g7QiAh5qpbmNDAXxV0iyLE Nb8IblIanr3jEmh3Y6wI6w3+LAf6tQMkRkUwgm0Ttxrc7HhZ1IVqOgtYhQGvZnVJ yPQGm9MIamnLGrmfb6T77wrXKBo9qzM+xcFqvjwhsQnQGyfJ3IMkKanczm1CzaNI +Zum6isJ7RrhS/jeevi9y9RJlVFm7VkfcyfKo6QmI3230zo/ot+nU6pCcE7a/tIT bxofC5EuaAvtFO6rXz+r =kz5y -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131122131727.GB7437>