From owner-cvs-all@FreeBSD.ORG  Tue Jun  7 01:02:27 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ACDD716A41C;
	Tue,  7 Jun 2005 01:02:27 +0000 (GMT) (envelope-from bms@spc.org)
Received: from arginine.spc.org (arginine.spc.org [83.167.185.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4DE8F43D48;
	Tue,  7 Jun 2005 01:02:24 +0000 (GMT) (envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 51C7B653AD; Tue,  7 Jun 2005 02:00:19 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
	by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id 01816-08-2; Tue,  7 Jun 2005 02:00:18 +0100 (BST)
Received: from empiric.dek.spc.org
	(82-35-114-35.cable.ubr07.dals.blueyonder.co.uk [82.35.114.35])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 55EBA6538E; Tue,  7 Jun 2005 02:00:18 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id BD0EC61E6; Tue,  7 Jun 2005 02:02:15 +0100 (BST)
Date: Tue, 7 Jun 2005 02:02:15 +0100
From: Bruce M Simpson <bms@spc.org>
To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org>
Message-ID: <20050607010215.GB821@empiric.icir.org>
Mail-Followup-To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org>,
	Nate Lawson <nate@root.org>, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
References: <20050606154917.7AEE716A42B@hub.freebsd.org>
	<42A490F2.4010705@root.org>
	<8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org>
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/dev/ata ata-raid.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2005 01:02:27 -0000

On Mon, Jun 06, 2005 at 08:37:09PM +0200, Søren Schmidt wrote:
> >>+    printf("magic_2             0x%016llx\n",(unsigned long long) 
> >>meta->magic_2);
> >
> >I think %jx is preferred to a cast.
> 
> I think I prefer the style of the rest of ATA.

I think I prefer portable code :-(

BMS