From owner-svn-ports-all@FreeBSD.ORG Mon Jul 21 05:14:59 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 37335DCB; Mon, 21 Jul 2014 05:14:59 +0000 (UTC) Received: from mail-pd0-x236.google.com (mail-pd0-x236.google.com [IPv6:2607:f8b0:400e:c02::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0C6E248C; Mon, 21 Jul 2014 05:14:58 +0000 (UTC) Received: by mail-pd0-f182.google.com with SMTP id fp1so8423738pdb.41 for ; Sun, 20 Jul 2014 22:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Gcb3UTMLo17jJtICO4i5+/VaKD/SgV2PXxVqrsx/OZ0=; b=JVxqzlmdPaH6agSUlGCx04ia0u0WYov2OzKocGe25Vgc4fgtR8BXD5+yq2uz4OcBRO SCKNYibYXihTnLpbNGaRWk0VtGg8497UJPl7RlR3mU9y4jInKEKVRMAalBiMytVz+0/i 3SF4DX72NpOXgodXq1jl21T7rstqKvLmyL09mf9nMf/ZTwToFAvMpuJzsgZ0lhOJZtle DsYCQUaW8bzh5Fz2i9cBUo4Q2E4e+53TQiVHeq4k4KRGsk6mGq3oG3EPnvwuxhMz2ySD iyDL1RYgLbpdROR6fN1FsgnpkegnRWhKq9XCtE26QutTXk4pTl3tQRyitIYh/+X0MWCy DjoQ== X-Received: by 10.70.54.102 with SMTP id i6mr22669577pdp.25.1405919698485; Sun, 20 Jul 2014 22:14:58 -0700 (PDT) Received: from [192.168.1.7] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id co3sm12800491pbb.89.2014.07.20.22.14.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jul 2014 22:14:57 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <53CCA1CC.8090900@FreeBSD.org> Date: Mon, 21 Jul 2014 15:14:52 +1000 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: python@freebsd.org Subject: Re: svn commit: r361263 - in head: . Mk References: <201407081614.s68GEXP0055616@svn.freebsd.org> <20140720231858.Horde.hH8gtABZabgnNKjWAXT_Yw7@webmail.df.eu> In-Reply-To: <20140720231858.Horde.hH8gtABZabgnNKjWAXT_Yw7@webmail.df.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "svn-ports-head@freebsd.org" , Antoine Brodin , mva@freebsd.org, "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 05:14:59 -0000 On 21/07/2014 7:18 AM, Marcus von Appen wrote: > > Antoine Brodin : > >> On Tue, Jul 8, 2014 at 6:14 PM, Marcus von Appen wrote: >>> Author: mva >>> Date: Tue Jul 8 16:14:33 2014 >>> New Revision: 361263 >>> URL: http://svnweb.freebsd.org/changeset/ports/361263 >>> QAT: https://qat.redports.org/buildarchive/r361263/ >>> >>> Log: >>> Support for installations based on the easy_install setup.py target >>> has >>> been removed from the Ports framework for Python software. The >>> PYEASYINSTALL_* knobs and support for USE_PYDISTUTILS=easy_install >>> have >>> been removed. >>> >>> Phabric: D299 >>> With hat: python@ >> >> Hi, >> >> There is a regression after this commit, more than 200 python modules >> that use USE_PYDISTUTILS=yes but don't use autoplist orphan their >> egginfo. > > Ouch! I thought that I tested everything often enough... > >>> @@ -574,10 +501,8 @@ PYDISTUTILS_EGGINFODIR?=${STAGEDIR}${PYT >>> add-plist-egginfo: >>> .if !defined(PYDISTUTILS_NOEGGINFO) && \ >>> !defined(PYDISTUTILS_AUTOPLIST) && \ >>> - (defined(INSTALLS_EGGINFO) || \ >>> - (defined(USE_PYDISTUTILS) && \ >>> - ${USE_PYDISTUTILS} != "easy_install")) && \ >>> - defined(PYTHON_REL) >>> + defined(INSTALLS_EGGINFO) && \ >>> + defined(PYTHON_REL) >>> . for egginfo in ${PYDISTUTILS_EGGINFO} >>> if [ -d "${PYDISTUTILS_EGGINFODIR}/${egginfo}" ]; then \ >>> ${LS} ${PYDISTUTILS_EGGINFODIR}/${egginfo} | while >>> read f; do \ > > The mistake seems to be here. This should be > > .if !defined(PYDISTUTILS_NOEGGINFO) && \ > !defined(PYDISTUTILS_AUTOPLIST) && \ > (defined(INSTALLS_EGGINFO) || defined(USE_PYDISTUTILS)) && \ > defined(PYTHON_REL) > ... > .endif > > I won't have the time to check and commit this in the next few days. > Can a python@'eer recheck and commit a fix please? > > Thanks > Marcus > > For reference, one of these was recently reported in math/py-numpy [1], fixed by adding INSTALLS_EGGINFO [2]. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191865 [2] http://svnweb.freebsd.org/changeset/ports/362060