Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Dec 2012 22:15:59 -0500
From:      Diane Bruce <db@db.net>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-ports-head@freebsd.org, Diane Bruce <db@freebsd.org>, Diane Bruce <db@db.net>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308561 - in head/comms/gnuradio: . files
Message-ID:  <20121210031559.GA12108@night.db.net>
In-Reply-To: <CAF6rxgmv7EHDt75Mr_ymWG=dnqwJpHQ5XuD-k_CVR4RgAN_RJw@mail.gmail.com>
References:  <201212092019.qB9KJfsr022686@svn.freebsd.org> <CAF6rxgnBsNU8KR0OWPWukQ3JTbiKVvVOwkdcjM80qDckjf=HvA@mail.gmail.com> <20121210023744.GA11683@night.db.net> <CAF6rxgmv7EHDt75Mr_ymWG=dnqwJpHQ5XuD-k_CVR4RgAN_RJw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 09, 2012 at 09:40:53PM -0500, Eitan Adler wrote:
> On 9 December 2012 21:37, Diane Bruce <db@db.net> wrote:
> > On Sun, Dec 09, 2012 at 06:32:38PM -0500, Eitan Adler wrote:
> >> On 9 December 2012 15:19, Diane Bruce <db@freebsd.org> wrote:
> >> > Author: db
> >> > Date: Sun Dec  9 20:19:41 2012
> >> > New Revision: 308561
> >> > URL: http://svnweb.freebsd.org/changeset/ports/308561
> >> >
> >> > Log:
> >> >   - Update to 3.6.2
> >> >   - Needs the usrp port
> >> >
> >> >   Tested by:    lrk@ovillatx.sytes.net
> >> >
> >> > Added:
> >> ...
> >> > Deleted:
> >> ...
> >> > Modified:
> >> >   head/comms/gnuradio/Makefile
> >> >   head/comms/gnuradio/distinfo   (contents, props changed)
> >> >   head/comms/gnuradio/pkg-descr   (contents, props changed)
> >> >   head/comms/gnuradio/pkg-plist   (contents, props changed)
> >>
> >> Wow, that is a lot of work.  I'm curious if upstream is willing to
> >> accept any of these to help reduce your burden in the future.
> >
> > I have submitted diffs to upstream before in the past. Obviously
> > I intend to submit these as well.
> 
> I didn't mean to imply you didn't.  I was just wondering on the status
> due to the shear number of them. :)

To answer Jason's criticism as well.

Yes I considered a simple REINPLACE but it was less work to get all the
fixups done so I have one common set of patches I can submit upstream.
I've had good experience with the gnuradio folks in the past accepting
our patches. I even signed a GPL release for gnuradio.

I had pinged my previous contact about these diffs but had not heard back yet.
I'll see if they want all these diffs sent in one batch to the patches list.
(Which I am on) I suspect they'll want them broken up some anyway.

Obviously as soon as these diffs go upstream it will clean up our side
quite a bit. You have yours truly to blame for BSD patches that made it
upstream from a few years ago.

As far as the DOCS vs. DOXYGEN thing goes. Yes. Mea culpa. It was a hack.
After I have had a break I'll redo it. Unless of course, someone else
volunteers.  Frankly, I need help or a break from staring at gnuradio code.

So. Help?

- Diane
-- 
- db@FreeBSD.org db@db.net http://www.db.net/~db
  Nowadays tar can compress using yesterdays latest technologies!



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121210031559.GA12108>