From owner-freebsd-threads@FreeBSD.ORG Fri Nov 27 22:30:58 2009 Return-Path: Delivered-To: threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7322F106566B; Fri, 27 Nov 2009 22:30:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id B659E8FC17; Fri, 27 Nov 2009 22:30:57 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nARMUhSa090334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Nov 2009 00:30:43 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nARMUgNv056905; Sat, 28 Nov 2009 00:30:42 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nARMUgNU056904; Sat, 28 Nov 2009 00:30:42 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 28 Nov 2009 00:30:42 +0200 From: Kostik Belousov To: Joe Marcus Clarke Message-ID: <20091127223042.GM2368@deviant.kiev.zoral.com.ua> References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> <1259349248.1608.36.camel@shumai.marcuscom.com> <4AF1E295-0524-4C39-94CD-9A12D574C64D@vigrid.com> <20091127213046.GI2368@deviant.kiev.zoral.com.ua> <1259358800.1608.46.camel@shumai.marcuscom.com> <20091127220706.GJ2368@deviant.kiev.zoral.com.ua> <1259359873.1608.48.camel@shumai.marcuscom.com> <20091127222224.GL2368@deviant.kiev.zoral.com.ua> <1259360887.1608.49.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yklP1rR72f9kjNtc" Content-Disposition: inline In-Reply-To: <1259360887.1608.49.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "threads@freebsd.org" Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 22:30:58 -0000 --yklP1rR72f9kjNtc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 27, 2009 at 05:28:07PM -0500, Joe Marcus Clarke wrote: > On Sat, 2009-11-28 at 00:22 +0200, Kostik Belousov wrote: > > On Fri, Nov 27, 2009 at 05:11:13PM -0500, Joe Marcus Clarke wrote: > > > I didn't see a better way of fixing this. I'm still fuzzy on how to = do > > > the correct symbol map dance for libthr/libc_r. Do you know of any > > > example symbols which had to be updated in this fashion? > >=20 > > pthread_condattr_init and _destroy are exported from libthr in FBSD_1.0. > > namespace. I think stubs should go into FBSD_1.0 namespace in libc then. > >=20 > > We nullified one of the use for symver by extending existing > > namespaces (symbol versioning, as defined by Sun, allowed for dynamic > > linker to make a guarantee that process does not have unresolved > > symbols only by checking that all required versions are provided > > by libraries). My opinion that adding them to FBSD_1.0 is ok. >=20 > That's easy enough. New patch is up. >=20 > http://www.marcuscom.com/downloads/stubs.diff I think symbols should be added in the pthread_* block of the libc/gen/Symbol.map, arranged alphabetically. --yklP1rR72f9kjNtc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAksQUxIACgkQC3+MBN1Mb4hbcwCfehMfWbZBUOtfEf3QxZbIvlJE /TsAnRrkxhd9xSNrm94DeiZ0cVGieINV =7/Bw -----END PGP SIGNATURE----- --yklP1rR72f9kjNtc--