From owner-freebsd-ports@FreeBSD.ORG Mon May 3 01:09:56 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4D5416A4CE for ; Mon, 3 May 2004 01:09:56 -0700 (PDT) Received: from smtp.dkm.cz (smtp.dkm.cz [62.24.64.34]) by mx1.FreeBSD.org (Postfix) with SMTP id 5D8F643D4C for ; Mon, 3 May 2004 01:09:55 -0700 (PDT) (envelope-from neuhauser@chello.cz) Received: (qmail 18068 invoked by uid 0); 3 May 2004 08:09:53 -0000 Received: from r3al16.mistral.cz (HELO isis.wad.cz) (213.220.229.16) by smtp.dkm.cz with SMTP; 3 May 2004 08:09:53 -0000 Received: by isis.wad.cz (Postfix, from userid 1001) id 816932FDA01; Mon, 3 May 2004 10:09:53 +0200 (CEST) Date: Mon, 3 May 2004 10:09:53 +0200 From: Roman Neuhauser To: Kris Kennaway Message-ID: <20040503080953.GA12341@isis.wad.cz> Mail-Followup-To: Kris Kennaway , Pete Fritchman , freebsd-ports References: <20040502050806.C12FB177CB@sirius.firepipe.net> <20040502070355.GA345@isis.wad.cz> <20040503065209.GA92943@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040503065209.GA92943@xor.obsecurity.org> User-Agent: Mutt/1.5.6i cc: Pete Fritchman cc: freebsd-ports Subject: Re: [PATCH] small speedups in Mk/bsd.port.mk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2004 08:09:56 -0000 # kris@obsecurity.org / 2004-05-02 23:52:09 -0700: > On Sun, May 02, 2004 at 09:03:55AM +0200, Roman Neuhauser wrote: > > > Hrmph, right, dot is just one of regexp metacharacters. > > This version uses plain string comparisons in DISTINFO_SIZE_AWK and > > DISTINFO_CKSUM_AWK. > > > > Thanks again for testing! This would have taken weeks if I submitted > > the patch right away. > > But that's why you should always test patches thoroughly before > submitting them, right? ;-) Yes, and I didn't mean to imply anything except that dealing with portmgr@ is slow business. As I said, my box has cooling problems, e. g. it couldn't finish two consecutive builds of mod_php4 yesterday. Plus, testing can't prove absence of bugs, and I of course tested all changes, but missed some things, like the fact that there are more RE metacharacters than just the dot. That's what public testing is good for, right? :) BTW any progress with ports/40699? Average response time from portmgr@ 7 months, and it's been suspended ("the patch doesn't apply anymore"; no wonder two years after it's been submitted :) for more than month despite three new versions of the patch? -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html