From owner-cvs-all Mon Mar 3 14: 8:33 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C66537B405 for ; Mon, 3 Mar 2003 14:08:31 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id CA77443FAF for ; Mon, 3 Mar 2003 14:08:29 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 78862 invoked by uid 1000); 3 Mar 2003 22:08:30 -0000 Date: Mon, 3 Mar 2003 14:08:30 -0800 (PST) From: Nate Lawson To: Robert Watson Cc: Jeff Roberson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_default.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 3 Mar 2003, Robert Watson wrote: > On Mon, 3 Mar 2003, Nate Lawson wrote: > > On Mon, 3 Mar 2003, Jeff Roberson wrote: > > > Hey, good work here. Do you think there would be any way to use the > > > vnode's char name in the generic sync routine? There are a few other > > > places where we msleep that could use a more specific name as well. > > > > Interesting idea but how would you suggest compressing that to 6 chars? > > I assume "show lockedvnodes" will always be supreme? And when I just > > glanced at the implementation of "show lockedvnodes", I noticed: > > mtx_lock(&mountlist_mtx); How can this be correct? > > It's not. I've been meaning to remove the locking from ddb for ages, and > I think Bruce also had patches floating around at one point. > > BTW, we now get some fascinating failure modes if you do: > > call boot(0) > > in ddb, since it runs in an interrupt context using a serial console, and > when the shutdown sequence tries to malloc storage, it panics... Please do this! I've noticed this failure for a while but I think it's non-deterministic and there are other problems. I never got around to looking into it though. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message