From owner-freebsd-current  Thu Feb 21 15:14:57 2002
Delivered-To: freebsd-current@freebsd.org
Received: from iguana.icir.org (iguana.icir.org [192.150.187.36])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F4CE37B402; Thu, 21 Feb 2002 15:14:51 -0800 (PST)
Received: (from rizzo@localhost)
	by iguana.icir.org (8.11.6/8.11.3) id g1LNEdZ54174;
	Thu, 21 Feb 2002 15:14:39 -0800 (PST)
	(envelope-from rizzo)
Date: Thu, 21 Feb 2002 15:14:39 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: Alfred Perlstein <bright@mu.org>
Cc: Bruce Evans <bde@zeta.org.au>,
	"M. Warner Losh" <imp@village.org>, current@FreeBSD.ORG,
	msmith@FreeBSD.ORG
Subject: Proposed patch for "/bin/sh: Argument list too long" when compiling LINT ...
Message-ID: <20020221151439.D53952@iguana.icir.org>
References: <20020218.174959.96666779.imp@village.org> <20020219193515.Y1320-100000@gamplex.bde.org> <20020219004144.A25474@iguana.icir.org> <20020219085306.GL12136@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020219085306.GL12136@elvis.mu.org>
User-Agent: Mutt/1.3.23i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

So, in this thread a few days ago i reported that the
list of arguments passed to mkdep can become quite large
and exceed kern.argmax, especially if your sources are not in the
default place and you are compiling a file with lots of options
such as LINT.

The place to fix (for -current) is sys/conf/kern.post.mk, and
as Alfred suggested, a fix involves using xargs (mkdep is already
invoked with -a). Unfortunately it is not entirely trivial because
the variable containing the argument list is a Make variable, and
any attempt to expand it in a command will result in the "Argument
list too long" error.

The best I could come up with is the following (modulo cut&paste
conversion of tabs in spaces), i.e. use make's .for to
copy the list of files into a file that we can then pass
to xargs.

Any better ideas ?

	cheers
	luigi

Index: kern.post.mk
===================================================================
RCS file: /home/ncvs/src/sys/conf/kern.post.mk,v
retrieving revision 1.4
diff -u -r1.4 kern.post.mk
--- kern.post.mk        2001/11/11 06:16:53     1.4
+++ kern.post.mk        2002/02/21 04:49:26
@@ -89,10 +89,28 @@
            ${SYSTEM_SFILES} ${MFILES:T:S/.m$/.h/}
	if [ -f .olddep ]; then mv .olddep .depend; fi
	rm -f .newdep
-	env MKDEP_CPP="${CC} -E" CC="${CC}" \
-	    mkdep -a -f .newdep ${CFLAGS} ${CFILES} ${SYSTEM_CFILES} ${GEN_CFILE
S}
-       env MKDEP_CPP="${CC} -E" \
-           mkdep -a -f .newdep ${ASM_CFLAGS} ${SFILES} ${SYSTEM_SFILES}
+       #
+       # The argument list can be very long, and the only way we have to
+       # split it is within make because anything else will cause
+       # an exec error if the list is too long!
+       rm -f .args
+.for I in ${CFILES} ${SYSTEM_CFILES} ${GEN_CFILES}
+               @echo -n "$I " >> .args
+.endfor
+       echo "" >> .args
+       echo "args len is " ; wc .args
+       # argument list...
+       cat .args | xargs env MKDEP_CPP="${CC} -E" CC="${CC}" \
+           mkdep -a -f .newdep ${CFLAGS}
+       rm -f .args
+.for I in ${SFILES} ${SYSTEM_SFILES}
+               @echo -n "$I " >> .args
+.endfor
+       echo "" >> .args
+       echo "args len is " ; wc .args
+       cat .args | xargs env MKDEP_CPP="${CC} -E" \
+           mkdep -a -f .newdep ${ASM_CFLAGS}
+       rm -f .args
        rm -f .depend
        mv .newdep .depend


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message