From owner-cvs-src@FreeBSD.ORG  Wed Aug 25 17:54:34 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0F13216A4CE; Wed, 25 Aug 2004 17:54:34 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8811143D53; Wed, 25 Aug 2004 17:54:33 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12])
	(authenticated bits=0)
	by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i7PHti4U000800;
	Wed, 25 Aug 2004 11:55:45 -0600 (MDT)
	(envelope-from scottl@freebsd.org)
Message-ID: <412CD20F.2090708@freebsd.org>
Date: Wed, 25 Aug 2004 11:53:19 -0600
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7) Gecko/20040514
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Nate Lawson <nate@root.org>
References: <200408231628.i7NGSg8G084516@repoman.freebsd.org>
	<20040824180620.GA56576@dragon.nuxi.com> <412B9629.3080108@root.org>
	<20040824213627.GA61527@dragon.nuxi.com> <412BC4C5.3000708@root.org>
In-Reply-To: <412BC4C5.3000708@root.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: obrien@freebsd.org
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpi_resource.c acpivar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2004 17:54:34 -0000

Nate Lawson wrote:
> David O'Brien wrote:
> 
>> On Tue, Aug 24, 2004 at 12:25:29PM -0700, Nate Lawson wrote:
>>
>>> David O'Brien wrote:
>>>
>>>> On Mon, Aug 23, 2004 at 04:28:42PM +0000, Nate Lawson wrote:
>>>>
>>>>
>>>>> njl         2004-08-23 16:28:42 UTC
>>>>> FreeBSD src repository
>>>>> Modified files:
>>>>>  sys/dev/acpica       acpi.c acpi_resource.c acpivar.h Log:
>>>>> Rework sysresource management.  Instead of having each sysresource 
>>>>> object
>>>>
>>>>
>>>> ...
>>>>
>>>>
>>>>> Tested by:      Pawel Worach <sajd_at_telia.com>
>>>>> Tested by:      Radek Kozlowski <radek_at_raadradd.com>
>>>>
>>>>
>>>>
>>>> Tested only on i386, right??
>>>
>>>
>>> Still waiting for the amd64 laptop donation.  ;-)  In any case, I've 
>>> just committed a fix.  The amd64,ia64 nexus hadn't been caught up 
>>> with i386 and the resource code depends on the new method.
>>
>>
>> In the future, may I make a request that you post patches for large
>> changes before committing them?  Now that ACPI is a multi-platform thing
>> that is very basic to booting, we have to be careful about changes to it.
> 
> 
> For large commits (i.e. mpsafe patch), I post patches and get testing. 
> For critical bugfixes like this, I get the reporter to test after I test 
> and then commit.  With the minimum MFC period, I want to get critical 
> bugfixes into HEAD as soon as they are tested (to start the clock) and 
> plan to be responsive to any subsequent bug reports.
> 

I'm not going to harp on this other than to say that commits to RELENG_5
need to have adequate review and testing before they are submitted for
approval.  I'll personally test anything that you need on amd64 if you
ask.

Scott