Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Sep 2010 19:29:32 -0700
From:      Marcel Moolenaar <xcllnt@mac.com>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r212614 - in head: sbin/geom/class/part sys/geom/part
Message-ID:  <F224CD9E-E32A-4395-9666-65CDAB6771C7@mac.com>
In-Reply-To: <201009141621.o8EGLDhr086248@svn.freebsd.org>
References:  <201009141621.o8EGLDhr086248@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sep 14, 2010, at 9:21 AM, Pawel Jakub Dawidek wrote:

> Author: pjd
> Date: Tue Sep 14 16:21:13 2010
> New Revision: 212614
> URL: http://svn.freebsd.org/changeset/base/212614
> 
> Log:
>  - Change all places where G_TYPE_ASCNUM is used to G_TYPE_NUMBER.
>    It turns out the new type wasn't really needed.
>  - Reorganize code a little bit.

Please revert. The gpart ctlreq interface is ASCII only by design.
This change is unnecessary as nothing was broken and on top of
that breaks compatibility with user-space -- again entirely without
merit.

Thanks,

-- 
Marcel Moolenaar
xcllnt@mac.com






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F224CD9E-E32A-4395-9666-65CDAB6771C7>