Date: Thu, 19 May 2005 15:47:37 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sparc64/isa isa.c Message-ID: <200505191547.j4JFlb6t045236@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marius 2005-05-19 15:47:37 UTC
FreeBSD src repository
Modified files:
sys/sparc64/isa isa.c
Log:
- When iterating over the register resources of the children don't use
the iteration variable as the RID when adding the respective resource
to the child via bus_set_resource(). In case a device has both I/O
and memory resources this generates gaps in the newbus resources of
the child, e.g. its first memory resource might end up as RID 1.
To solve this mimic resource_list_add_next() via resource_list_find()
and bus_set_resource(); we can't just use resource_list_add_next()
here as this would circumvent the limit checks in isa_set_resource()
of the common ISA code.
This however is more or less a theoretical problem so far as all known
ISA devices on sparc64 soley use I/O space.
- Just use bus_generic_rl_release_resource() for isa_release_resource()
instead of re-implementing the former.
- Improve some comments to better reflect reality, minor clean-up and
simplifications, return NULL instead of 0 were appropriate.
Revision Changes Path
1.16 +33 -27 src/sys/sparc64/isa/isa.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505191547.j4JFlb6t045236>