Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Jan 2017 14:20:06 -0800
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Luiz Otavio O Souza <loos@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r312770 - in head/sys: net netinet netinet6
Message-ID:  <20170125222006.GH2611@FreeBSD.org>
In-Reply-To: <201701251904.v0PJ48YF061428@repo.freebsd.org>
References:  <201701251904.v0PJ48YF061428@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
  Thanks, Luiz!

  One stylistic nit that I missed in review:

L>  static int
L> -in_difaddr_ioctl(caddr_t data, struct ifnet *ifp, struct thread *td)
L> +in_difaddr_ioctl(u_long cmd, caddr_t data, struct ifnet *ifp, struct thread *td)
L>  {
L>  	const struct ifreq *ifr = (struct ifreq *)data;
L>  	const struct sockaddr_in *addr = (const struct sockaddr_in *)
L> @@ -618,7 +618,8 @@ in_difaddr_ioctl(caddr_t data, struct if
L>  	in_ifadown(&ia->ia_ifa, 1);
L>  
L>  	if (ia->ia_ifa.ifa_carp)
L> -		(*carp_detach_p)(&ia->ia_ifa);
L> +		(*carp_detach_p)(&ia->ia_ifa,
L> +		    (cmd == SIOCDIFADDR) ? false : true);

Can we change the very last line to:

		    (cmd == SIOCAIFADDR) ? true : false);

I think that would be more straightforward. Do you agree? Sorry for not
noticing that before.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170125222006.GH2611>