From owner-freebsd-mips@FreeBSD.ORG Tue Jun 16 05:18:40 2015 Return-Path: Delivered-To: freebsd-mips@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88C7DF62; Tue, 16 Jun 2015 05:18:40 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qc0-x234.google.com (mail-qc0-x234.google.com [IPv6:2607:f8b0:400d:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4122EF81; Tue, 16 Jun 2015 05:18:40 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qcej3 with SMTP id j3so1524698qce.3; Mon, 15 Jun 2015 22:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=d2zgaOl8dTXEVdjamLSu9xh3w4isVkWYqwK+8Ev88k4=; b=KFla0NWkUGQlt9YU5L0rpWlgIra0krMA5mzoJyzXMqqT7/IkwD4RIdNCJ0/Lq1HzXu QYgWuGYsxBiq42LdzpH8bxXyXngtWTmnjRR9YtyB/f/m45yK1uY3oSUzPUGN8TJGSrSP WR3+x1cHMM+jFW+Yo8NCtejyfpwWD9QSK/G/gaj+xTKtm/p7hQnTnHsPEb+46So2OkI6 5N6kgq0qHiO5xfl0+LWLKKFFleBWNYwezBoZcKPQGO+dBejuCEmdZ3br3mAdpmGqSbN2 LuQKxBgOX6vq3QQSezR7JpCKfWQVem00+5ibnuJTmtRRSsqmP9GVzAVPe/9m3E/bzlIe xhtA== X-Received: by 10.140.216.83 with SMTP id m80mr42509039qhb.14.1434431919205; Mon, 15 Jun 2015 22:18:39 -0700 (PDT) Received: from kan ([2601:18f:0:1570:226:18ff:fe00:232e]) by mx.google.com with ESMTPSA id i90sm3239113qkh.5.2015.06.15.22.18.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2015 22:18:38 -0700 (PDT) Date: Tue, 16 Jun 2015 01:18:32 -0400 From: Alexander Kabaev To: Adrian Chadd Cc: "freebsd-mips@freebsd.org" Subject: Re: [rfc] fix umul_ppmm() in our libgcc Message-ID: <20150616011832.146e0f0e@kan> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/3d+MeqRa5bvdTBGI0e9/E5h"; protocol="application/pgp-signature" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 05:18:40 -0000 --Sig_/3d+MeqRa5bvdTBGI0e9/E5h Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 13 Jun 2015 15:41:34 -0700 Adrian Chadd wrote: > Hi, >=20 > our libgcc in -base is very .. old. It chokes when compiling for > mips32. This patch seems to do the right thing. >=20 > Does anyone have any positive/negative feedback? >=20 > Thanks, >=20 >=20 > -adrian Newer version of GCC use similar construct, but actual multiplication is done using more correct selection of casts: UDItype __x =3D (UDItype) (USItype) (u) * (USItype) (v); I suggest you follow their lead. No objections otherwise. --=20 Alexander Kabaev --Sig_/3d+MeqRa5bvdTBGI0e9/E5h Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVf7GoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+ky0P/2GMR7QLcs53VX/Hz3cNBZ/n 02VBYoUvWs7VJ/fVn4+jGeZyO1LR+Qwu9WcDaeEONo/4PsfuCNjZ7etMIaXG9dt8 KhQugRx9soh3040EniwVXc1lBASCVhkWA3k2PKWyyPfDwEqZ14f3/DdB6iPCMHpu mxA1y+MRF9j4pAmusYya4SyT9ThhHQhC+2reaoBvUpPG8neA6K6kyGi5+ZL7Ejqh WGKXfEjV+AGIvoI4DpUVXvahy/hTY1D6nQlHbwypxepv7FLh5czwh7Pk3kwmITsb hvsVpkWl0pS8iUsHUpIXQR1F/zBfcAb/MqcsYOlLW6pYwj8KfHUWiylfj4h5IM7i DS+c9fbltrOsC634Kb0cCEB7/fLN4VR1qM8g9gkSRMBbyDH2gHYy7h3//hetXrRN D3PgyL945rnfssz3IUTwwUxEyyn8cyostpuDsfTNboRL/FiQDT7h3Qd+FvLN/F4b +d9nbze3reEauAxQQQKEdi+/C7GPkjWbMlf/U5ezpwUhnbbjsy6wsnGAg/N4W7qB mRC3tpCdEkYHuF55LgAFlmCdht+zrYBsmMt4ZENQE+SwJCW+gyJUgva0GJltG3Iv jPccIr4h1Iy2FLNYOYYfxo/0o6gSG5vQSHaa7mZ5Ueyprnal6FrATBhdn+B9Gcun qt5bkdJHec+O4fP6hWTQ =bzBe -----END PGP SIGNATURE----- --Sig_/3d+MeqRa5bvdTBGI0e9/E5h--