From owner-svn-ports-head@FreeBSD.ORG Thu Nov 22 05:49:20 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 78ECB5EE; Thu, 22 Nov 2012 05:49:20 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.6.71]) by mx1.freebsd.org (Postfix) with ESMTP id 022D88FC14; Thu, 22 Nov 2012 05:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=llWG5noxJCw/dGV4chK+1c4cGt2X/Vg43R3r7+IjnDE=; b=Z2FpIPwYqGpV0RTYPWKXH8rytmljDD3A/X2QO3dmZPMyBJnGLGHoMNw8VLlFxxVwBXlHBO46yw0h7QBvDww/g6iFP7GPmgz6zftXN3GtStTZAPcVb1UsBG4+hMfH/IHhCgRzvp72oNWgkgjmvnct0BkkgMDCnThMOLZ0v12bzuWeBcsCfKVCDTKtKOLD31PKhYMClY0seTScND+otQdU/IlIeFEEfRFpe9BwlFJkCiHw3MlqFg7M5heVhDZLPE7KRgLxCBG9qKdEjRhbqKvG3pVycrYIUaUJvC9Ra44n8xBAAFjgrS2ohXW+Zeve/8ftW6OVTP/JhYvYbNm24MvlNTl7HJEU2lwdhS+T69+mROv4xwr6eSJr/Qskn23pMR+ARhYt+dN2OxfgbBXg4BZce5FlQH3l6O3ToG4wLphP3aUDvVi6wqCD9QnDlIVT5FlEpZpOrxWPerzLqme2mHQSqENYqJt2/XyHQvxkISlqMYX9KxTYd8KnRvtr/CAWxqPey6dSulTyyc/0+KQUsi+tpQrru/Z3Awox4QFlvAAbmW7mKmOmASCHoMRjELlVSwvWRQeeRayamyYzCHFBEsaUfq7fjXobw8DWo4By2LUesD/p/kuNTaWCh5pq/oTrwUn42btv72IpDBbg6/D/rRO4Bp3Mr1wQc+BD/3hy2fvJWn0=; Received: from void.codelabs.ru (void.codelabs.ru [144.206.6.66]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) id 1TbPf2-0002UG-Hr; Thu, 22 Nov 2012 09:49:16 +0400 Date: Thu, 22 Nov 2012 09:49:13 +0400 From: Eygene Ryabinkin To: Bryan Drewery Subject: Re: svn commit: r307612 - in head/misc/astrolog: . files Message-ID: References: <201211210949.qAL9nl4a018306@svn.freebsd.org> <50ACB0A7.1030108@freebsd.org> <50ACBE7D.70203@freebsd.org> <20121121120128.GC4474@droso.net> <50ACF8E8.5080706@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GPJrCs/72TxItFYR" Content-Disposition: inline In-Reply-To: <50ACF8E8.5080706@FreeBSD.org> Sender: rea@codelabs.ru Cc: svn-ports-head@freebsd.org, Andrey Chernov , svn-ports-all@freebsd.org, ports-committers@freebsd.org, Erwin Lansing , Chris Rees X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2012 05:49:20 -0000 --GPJrCs/72TxItFYR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wed, Nov 21, 2012 at 09:53:12AM -0600, Bryan Drewery wrote: > I agree. Splitting logically-grouped changes out into multiple patches > is confusing, especially to future maintainers. >=20 > IMHO this should not be a hard rule, but a suggestion if ordering is > problematic. Yes, but current porter guidelines say "Each patch you wish to apply should be saved into a file named patch-* where * indicates the pathname of the file that is patched, such as patch-Imakefile or patch-src-config.h" and "To make fixes and upgrades easier, you should avoid having more than one patch fix the same file (e.g., patch-file and patch-file2 both changing WRKSRC/foobar.c)", http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-pa= tch.html so, a. if SHOULD is as per RFC 2119, then it means that the recommended way is to have per-file patches and the other ways should be used with the great care; b. "make fixes and upgrades easier" concern only the short-term easiness (if at all), in the long term it has just the opposite effect for non-trivial patches. I think I'll try to come up with the patch for the handbook and will post it to the wider list for comments. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --GPJrCs/72TxItFYR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EABEIAAYFAlCtvNkACgkQFq+eroFS7PvzxgD+LSY9lGjJ+aI5XYH1etRPoz7x ahwZ+DKZlZfg7xImED8A/3v1bAZXyu8dH3yINPJuE2ZZoM5nCbTCcm3Edx2n4xbu =kMiK -----END PGP SIGNATURE----- --GPJrCs/72TxItFYR--