From owner-freebsd-arch@freebsd.org Sat Oct 1 12:45:42 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9419CC059E3 for ; Sat, 1 Oct 2016 12:45:42 +0000 (UTC) (envelope-from lew@perftech.com) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.194.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp-gw.pt.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62A87186B for ; Sat, 1 Oct 2016 12:45:41 +0000 (UTC) (envelope-from lew@perftech.com) X-ASG-Debug-ID: 1475325820-09411a12c01132ed0001-RYubVt Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id BTMpfXGbpPIFZeox (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 01 Oct 2016 07:43:40 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id AA60A8425FE; Sat, 1 Oct 2016 07:43:40 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id ZFisx77CewEg; Sat, 1 Oct 2016 07:43:40 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 5AFDB8425FF; Sat, 1 Oct 2016 07:43:40 -0500 (CDT) X-Virus-Scanned: amavisd-new at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id h3DBg9qQbD4L; Sat, 1 Oct 2016 07:43:40 -0500 (CDT) Received: from lewhome-dhcp-179.pt.net (lewhome-dhcp-179.pt.net [206.210.207.179]) (Authenticated sender: lew@pt.net) by mail.pt.net (Postfix) with ESMTPSA id 0E96A8425FE; Sat, 1 Oct 2016 07:43:39 -0500 (CDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 From: Lewis Donzis X-ASG-Orig-Subj: Re: mq on kqueue broken after upgrade to FreeBSD 11 In-Reply-To: <20161001092515.GW38409@kib.kiev.ua> Date: Sat, 1 Oct 2016 07:43:39 -0500 Cc: Alexander Kabaev , deischen@freebsd.org, freebsd-arch@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7CEF9718-2583-4EF1-BBBA-34A3B2F2F0E0@perftech.com> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan> <20161001092515.GW38409@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.3124) X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1475325820 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1434 X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.33374 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Oct 2016 12:45:42 -0000 > On Oct 1, 2016, at 4:25 AM, Konstantin Belousov = wrote: >=20 > On Fri, Sep 30, 2016 at 06:44:18PM -0400, Alexander Kabaev wrote: >> No objection, but possible suggestion: if the primary use of this >> symbol is for tests and nothing else, maybe it does belong in >> FBSDprivate_1.0 FBSDprivate_1.0 section instead? >=20 > Good question. The symbols are useful for real-world code, not only = for > the tests. But I think that we should mark symbol as non-portable. = Usual > approach of adding _np suffix seems to be the right thing to do there. >=20 > What about the following ? > =E2=80=A6 Not that I have any say in this, but that seems reasonable to me. The = functions are relevant and necessary for anything that needs a handle = for a POSIX message queue, so your change would be preferable to having = them appear as internal functions. (And then they could be documented, = too.) Speaking of which, not sure if this is the appropriate place to post = this, but the mq_open documentation needs a little tweaking, too. mq_open(2)=E2=80=99s man page says: SEE ALSO mq_close(2), mq_getattr(2), mq_receive(2), mq_send(2), = mq_setattr(2), mq_timedreceive(3), mq_timedsend(3), mq_unlink(3), mqueuefs(5) However, both mq_timedreceive and mq_timedsend are in section 2, not = section 3. =20 And, mq_unlink should probably be in section 2, but in any event, that = file appears to be missing. lew