Date: Wed, 2 Oct 2002 23:21:44 -0400 (EDT) From: Matt Emmerton <matt@gsicomp.on.ca> To: FreeBSD-gnats-submit@FreeBSD.org, itojun@FreeBSD.org Subject: kern/43611: static-ize some symbols in sys/crypto Message-ID: <200210030321.g933LiF7023407@dhcp2.gsicomp.on.ca>
next in thread | raw e-mail | index | archive | help
>Number: 43611 >Category: kern >Synopsis: static-ize some symbols in sys/crypto >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 02 20:30:00 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Matt Emmerton >Release: FreeBSD 5.0-CURRENT i386 >Organization: GSI Computer Services >Environment: System: FreeBSD laptop.gsicomp.on.ca 5.0-CURRENT FreeBSD 5.0-CURRENT #5: Mon Sep 23 21:24:44 EDT 2002 root@laptop.gsicomp.on.ca:/usr/obj/usr/src/sys/LAPTOP.20020914.01 i386 >Description: PKH's JKH TODO List - kernel orphan symbol review This patch makes some symbols in sys/crypto static, as they are not used outside the scope of this code and do not need to be visible. >How-To-Repeat: >Fix: --- sys/crypto/rijndael/boxes-fst.dat.orig Wed Oct 2 23:15:21 2002 +++ sys/crypto/rijndael/boxes-fst.dat Wed Oct 2 23:15:41 2002 @@ -1,7 +1,7 @@ /* $FreeBSD: src/sys/crypto/rijndael/boxes-fst.dat,v 1.2 2001/06/11 12:38:55 ume Exp $ */ /* $KAME: boxes-fst.dat,v 1.6 2001/05/27 00:23:22 itojun Exp $ */ -const word8 S[256] = { +static const word8 S[256] = { 99, 124, 119, 123, 242, 107, 111, 197, 48, 1, 103, 43, 254, 215, 171, 118, 202, 130, 201, 125, 250, 89, 71, 240, 173, 212, 162, 175, 156, 164, 114, 192, 183, 253, 147, 38, 54, 63, 247, 204, 52, 165, 229, 241, 113, 216, 49, 21, --- sys/crypto/sha2/sha2.c.orig Wed Oct 2 23:14:53 2002 +++ sys/crypto/sha2/sha2.c Wed Oct 2 23:15:01 2002 @@ -202,9 +202,9 @@ * library -- they are intended for private internal visibility/use * only. */ -void SHA512_Last(SHA512_CTX*); -void SHA256_Transform(SHA256_CTX*, const sha2_word32*); -void SHA512_Transform(SHA512_CTX*, const sha2_word64*); +static void SHA512_Last(SHA512_CTX*); +static void SHA256_Transform(SHA256_CTX*, const sha2_word32*); +static void SHA512_Transform(SHA512_CTX*, const sha2_word64*); /*** SHA-XYZ INITIAL HASH VALUES AND CONSTANTS ************************/ >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210030321.g933LiF7023407>