From owner-cvs-all@FreeBSD.ORG Wed Oct 6 15:30:50 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0A09216A4CE; Wed, 6 Oct 2004 15:30:50 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i96FUmF7063565; Wed, 6 Oct 2004 11:30:48 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i96FUgxj063564; Wed, 6 Oct 2004 11:30:42 -0400 (EDT) (envelope-from green) Date: Wed, 6 Oct 2004 11:30:42 -0400 From: Brian Fundakowski Feldman To: "Christian S.J. Peron" Message-ID: <20041006153042.GI47017@green.homeunix.org> References: <200410060040.i960efqj089441@repoman.freebsd.org> <20041006151749.GA56513@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041006151749.GA56513@freefall.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: David Xu cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_exec.c kern_thread.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 15:30:50 -0000 On Wed, Oct 06, 2004 at 03:17:49PM +0000, Christian S.J. Peron wrote: > On 6 Oct 2004 David Xu wrote: > > davidxu 2004-10-06 00:40:41 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys proc.h > > sys/kern kern_exec.c kern_thread.c > > Log: > > In original kern_execve() code, at the start of the function, it forces > > all other threads to suicide, problem is execve() could be failed, and > > a failed execve() would change threaded process to unthreaded, this side > > effect is unexpected. > > Should this be an MFC canidate? I think that it's fair to say every committer should to his or her capacity do a cvs diff -rRELENG_5 -rHEAD at some point, and see if they notice any changes that really should be merged, and haven't been. So even though I don't really put "MFC" in any of my recent commits, it's fair to say I'm going to review them again and decide which ones should probably be MFCed. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\