From owner-freebsd-net@FreeBSD.ORG Thu Mar 11 07:32:34 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 438FF1065676 for ; Thu, 11 Mar 2010 07:32:34 +0000 (UTC) (envelope-from egorenar@googlemail.com) Received: from mail-ew0-f228.google.com (mail-ew0-f228.google.com [209.85.219.228]) by mx1.freebsd.org (Postfix) with ESMTP id CA1F78FC08 for ; Thu, 11 Mar 2010 07:32:33 +0000 (UTC) Received: by ewy28 with SMTP id 28so2611275ewy.13 for ; Wed, 10 Mar 2010 23:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=fDwyo6KfssP9FQSb82c1hYmyGyNjnkuT4EfTgUB0LEE=; b=r9DSKbu6bclXfMSxUapC8ctBZ3m8yHJdwjdzTbL1+Kbhf4Wew97oasJK1Ba9Df+ZSX eHWraedfI6+M37vSS9PA+wgrRKBzpmDZyvGsGes2rA2OywHXQCi+aO2eVrSb48G/xew6 j4fh8QPMFnLo0BInXLcIslHQuVjBhQyCRC8Oc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=qwfFHHqsDA3WWB8r65Tb86PC6IrNR1tYdME8k6GRmtxl6JNc4BxCxRuUtTlrRRQSrQ 5g84A8xwSq+Bf5K1EBm7qKK3KDPS7OWJqci0/qdmUyD1/V/bTACgk2YwID0xzeFXvmPd SMiNFcfeOdQtZCEmSqOsQSDeYFPLI3Dt8lMD4= MIME-Version: 1.0 Received: by 10.213.1.135 with SMTP id 7mr1737947ebf.91.1268292752837; Wed, 10 Mar 2010 23:32:32 -0800 (PST) In-Reply-To: References: <2d3b7e441003042348h2150de3eub5a7af5248b5e947@mail.gmail.com> <4B92F057.9080508@errno.com> <2d3b7e441003070004r74646cdci268a5101056c50e2@mail.gmail.com> Date: Thu, 11 Mar 2010 08:32:32 +0100 Message-ID: <2d3b7e441003102332l1cc9b9ddh1e62fce61129248@mail.gmail.com> From: Alexander Egorenkov To: Rui Paulo Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org Subject: Re: Setting HT capabilities in net80211 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 07:32:34 -0000 There are already constants defined in iee80211.h. E.g. IEEE80211_HTCAP_MCSFBACK_UNSOL. But the problem is that e.g. IEEE80211_HTCAP_MCSFBACK_UNSOL is equal to 0x0200 and the capabilty constant IEEE80211_HTCAP_RXSTBC_2STREAM has the same value. So we cannot use ic_htcap field for both capabilities because they will overwrite each other. But we can add a new field to ieee80211com struct like ic_htextcaps where all the extended HT capabilities can be set. And this new field can be checked in function ieee80211_add_htcap_body. Another option is to change the value of IEEE80211_HTCAP_MCSFBACK_UNSOL and all other extended capability constant which conflict with normal HT capability constants. Or do you have any other ideas ? On Thu, Mar 11, 2010 at 7:59 AM, Rui Paulo wrote: > On 7 Mar 2010, at 17:04, Alexander Egorenkov wrote: > > OK, here is an example. >> >> There is no way to set MCS feedback capability in the filed hc_extcap of >> the >> struct ieee80211_ie_htcap >> because the function ieee80211_add_htcap_body always sets it to 0. And my >> Ralink device supports MCS feedback >> according to Linux device driver code. The same problem is with HTC+ and >> RDR >> capabilities. >> > > Just add another driver HT bit flag and patch the function to honor that > flag. Then send us the patch. :-) > > -- > Rui Paulo > >