Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jul 2017 10:29:55 +0200
From:      Guido Falsi <madpilot@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r445400 - in head/deskutils/calibre: . files
Message-ID:  <98932617-a181-76b7-7392-5f04ccc6d43e@FreeBSD.org>
In-Reply-To: <61f7e706-5c92-e4e4-ab5f-a952aa42c89b@FreeBSD.org>
References:  <201707091013.v69ADnGE029028@repo.freebsd.org> <61f7e706-5c92-e4e4-ab5f-a952aa42c89b@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07/11/17 08:41, Mathieu Arnold wrote:
> Le 09/07/2017 à 12:13, Guido Falsi a écrit :
>> +python_OLD_CMD=	"/usr/bin/env python" /bin/python /usr/bin/python /usr/local/bin/python \
>> +		"/usr/bin/env python2" /bin/python2 /usr/bin/python2 /usr/local/bin/python2
> 
> All the values on the first line already are present in python_OLD_CMD,
> so now, they are here twice:
> 
> $ make -V python_OLD_CMD
> "/usr/bin/env python" /bin/python /usr/bin/python /usr/local/bin/python 
> "/usr/bin/env python2" /bin/python2 /usr/bin/python2
> /usr/local/bin/python2 "/usr/bin/env python" /bin/python /usr/bin/python
> /usr/local/bin/python
> 
> 
> You should remove them and only add values that are not already there.
> 

You're definitely right, sorry for the misuse of the variable. I did not
properly check how the content was being used and assumed, wrongly, I
would be overriding the defaults.

Thanks, I'll fix it shortly.

-- 
Guido Falsi <madpilot@FreeBSD.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?98932617-a181-76b7-7392-5f04ccc6d43e>