Date: Thu, 20 Jan 2000 11:12:13 +0100 From: Adrian Chadd <adrian@freebsd.org> To: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_aio.c Message-ID: <20000120111213.A1357@leia.creative.net.au> In-Reply-To: <20000119233311.X27689@sturm.canonware.com> References: <20000119210539.F20191@fw.wintelcom.net> <Pine.BSF.4.21.0001201741580.2347-100000@alphplex.bde.org> <20000119225846.W27689@sturm.canonware.com> <20000119233702.E20751@fw.wintelcom.net> <20000119233311.X27689@sturm.canonware.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 19, 2000, Jason Evans wrote: > On Wed, Jan 19, 2000 at 11:37:02PM -0800, Alfred Perlstein wrote: > > Jason Evans <jasone@canonware.com> [000119 23:24] wrote: > > > The person who sent me the patch was convinced that it was a necessary > > > change due to problems he had run into, and he convinced me at the time, > > > though my understanding of the code isn't great. > > > > > > Contrary to a previous statement, I'm going to leave the code as is for now > > > and actually write some test code to try to produce a problem with/without > > > the change. > > > > Can you post the issue he brought up that needed the spl lifted? > > No. It was in an xchat (IRC) buffer that crashed. =( I think he was seeing > permanently blocked processes. Twas me, and I was getting the system locking up in tsleep(). I wasn't entirely sure of the splx() fix, obviously I was looking at the wrong place, thanks for pointing it out. I'll spend some time today tidying up the other few places (eg lio_listio() ) where a similar race condition might occur, and I'll see if I can lock up the box with the splx() change reverted. Since I'm abusing the AIO code rather heavily now, I should be able to expose some bugs that might exist. The only other person I know of that is using the AIO code is Chris Sedore, but I don't know how heavy he's using the code (and whether he's doing disk IO + socket IO like I'm doing right now.) Adrian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000120111213.A1357>