From owner-cvs-all  Wed Jan 10 20:43: 6 2001
Delivered-To: cvs-all@freebsd.org
Received: from netau1.alcanet.com.au (ntp.alcanet.com.au [203.62.196.27])
	by hub.freebsd.org (Postfix) with ESMTP
	id 34EFC37B400; Wed, 10 Jan 2001 20:42:45 -0800 (PST)
Received: from mfg1.cim.alcatel.com.au (mfg1.cim.alcatel.com.au [139.188.23.1])
	by netau1.alcanet.com.au (8.9.3 (PHNE_22672)/8.9.3) with ESMTP id PAA29744;
	Thu, 11 Jan 2001 15:42:41 +1100 (EDT)
Received: from gsmx07.alcatel.com.au by cim.alcatel.com.au
 (PMDF V5.2-32 #37641) with ESMTP id <01JYSBDUFIDSEMXJ0G@cim.alcatel.com.au>;
 Thu, 11 Jan 2001 15:42:49 +1100
Received: (from jeremyp@localhost)	by gsmx07.alcatel.com.au (8.11.0/8.11.0)
 id f0B4gbg93019; Thu, 11 Jan 2001 15:42:37 +1100 (EST envelope-from jeremyp)
Content-return: prohibited
Date: Thu, 11 Jan 2001 15:42:37 +1100
From: Peter Jeremy <peter.jeremy@alcatel.com.au>
Subject: Re: cvs commit: src/sys/ufs/ufs ufs_extattr.c
In-reply-to: <200101072107.f07L7Ps13036@freefall.freebsd.org>; from
 rwatson@FreeBSD.ORG on Sun, Jan 07, 2001 at 01:07:25PM -0800
To: Robert Watson <rwatson@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Mail-followup-to: Robert Watson <rwatson@FreeBSD.ORG>,
 cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Message-id: <20010111154237.A91242@gsmx07.alcatel.com.au>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-disposition: inline
User-Agent: Mutt/1.2.5i
References: <200101072107.f07L7Ps13036@freefall.freebsd.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On 2001-Jan-07 13:07:25 -0800, Robert Watson <rwatson@FreeBSD.ORG> wrote:
>rwatson     2001/01/07 13:07:25 PST
>
>  Modified files:
>    sys/ufs/ufs          ufs_extattr.c 
>  Log:
>  o Remove unnecessary sanity check involving requested offset of extended
>    attribute read--the offset is required to be 0 by an earlier check,
>    meaning that it will always be within the scope of the attribute data.
>    This change should have no impact on executed code paths other than
>    removing the unnecessary check: please report if any new failures
>    start to occur as a result.

Couldn't this have been changed to a KASSERT?  This would provide a
fairly clear indication that something has gone wrong.

Peter


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message