From owner-freebsd-net@FreeBSD.ORG Thu Mar 11 07:44:28 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D358B106566B for ; Thu, 11 Mar 2010 07:44:28 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 85AF08FC0C for ; Thu, 11 Mar 2010 07:44:28 +0000 (UTC) Received: by gwj15 with SMTP id 15so810026gwj.13 for ; Wed, 10 Mar 2010 23:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=HjIeUtv5+yQMSdGWe4m+FecksVn+USKyYJfyfmvrTgI=; b=Qdm95oKXlBWdgX1uKeTqpY+1X1Qp0I5y9Gb4NOlmDxz4mSS+ef7+Uh/D1Gt6sysFFN mRBn+JbxnBNR9HOy4i/un1YAFWoenZ1pZUsgmbUige5Sy5Capy+X1lUceugwJQ+pebQI cgtcH30MuKsZv1oF0kZcoFGM1xvJJNbB9dfyM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=c5WJ8Ow0lzEGLZ9nKxNSWist7xTVOd1Sxv17coSs4dKQNVTWaUNAjW8aA6KRS/MuZu 4Wwlk2wpl741hYVgJpL9fan1UUSWVJyhBW+mWgMzQRmNrP4IqD/rw1facDqo+SflLysM f1pEnIZvW5zeuB7X0SSZUxNYKr1vi22SgeJvw= Received: by 10.101.208.9 with SMTP id k9mr3636335anq.31.1268293467733; Wed, 10 Mar 2010 23:44:27 -0800 (PST) Received: from [192.168.11.61] (197.214.32.202.bf.2iij.net [202.32.214.197]) by mx.google.com with ESMTPS id 13sm5790648gxk.0.2010.03.10.23.44.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Mar 2010 23:44:26 -0800 (PST) Sender: Rui Paulo Message-Id: <6A317237-60A2-440A-9DBC-511545C34B36@FreeBSD.org> From: Rui Paulo To: Alexander Egorenkov In-Reply-To: <2d3b7e441003102332l1cc9b9ddh1e62fce61129248@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Thu, 11 Mar 2010 16:44:22 +0900 References: <2d3b7e441003042348h2150de3eub5a7af5248b5e947@mail.gmail.com> <4B92F057.9080508@errno.com> <2d3b7e441003070004r74646cdci268a5101056c50e2@mail.gmail.com> <2d3b7e441003102332l1cc9b9ddh1e62fce61129248@mail.gmail.com> X-Mailer: Apple Mail (2.936) Cc: freebsd-net@freebsd.org Subject: Re: Setting HT capabilities in net80211 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 07:44:28 -0000 On 11 Mar 2010, at 16:32, Alexander Egorenkov wrote: > There are already constants defined in iee80211.h. > E.g. IEEE80211_HTCAP_MCSFBACK_UNSOL. > > But the problem is that e.g. IEEE80211_HTCAP_MCSFBACK_UNSOL is equal > to 0x0200 > and the capabilty constant IEEE80211_HTCAP_RXSTBC_2STREAM has the > same value. > So we cannot use ic_htcap field for both capabilities because they > will overwrite each other. > > But we can add a new field to ieee80211com struct like ic_htextcaps > where all the extended > HT capabilities can be set. And this new field can be checked in > function ieee80211_add_htcap_body. I'm okay with this route. > Another option is to change the value of > IEEE80211_HTCAP_MCSFBACK_UNSOL and all other extended capability > constant which conflict with normal HT capability constants. I think you don't want to do this because sooner or later you'll need ic_htextcaps. -- Rui Paulo