From owner-cvs-all@FreeBSD.ORG Wed Mar 1 03:36:29 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49BA916A420 for ; Wed, 1 Mar 2006 03:36:29 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: from nproxy.gmail.com (nproxy.gmail.com [64.233.182.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id E813A43D4C for ; Wed, 1 Mar 2006 03:36:26 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: by nproxy.gmail.com with SMTP id p77so23023nfc for ; Tue, 28 Feb 2006 19:36:25 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ZpDIFlTnsS1ZQAWNzJDtwEU7L4Vfbhn2CTA6y46bY8EiBXdATIWvENTFbXJL1wp2yJDeAz8dLf27oMrVwOUlzAJFK68P6+YFx+oPs2twMa+Gah3QjNysfTmGuR7oDGJs+EilaqfkF2Nz+kE6kbkBkxRPcBnksZ6NkXSqv+tP/nY= Received: by 10.49.56.6 with SMTP id i6mr830712nfk; Tue, 28 Feb 2006 19:36:25 -0800 (PST) Received: by 10.49.4.2 with HTTP; Tue, 28 Feb 2006 19:36:25 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2006 19:36:25 -0800 From: "Maksim Yevmenkin" To: "Scott Long" In-Reply-To: <44050B67.3040302@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200602282346.k1SNkNHq073716@repoman.freebsd.org> <4404FCC8.5070907@samsco.org> <44050B67.3040302@samsco.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbd kbd.c src/sys/dev/syscons syscons.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2006 03:36:29 -0000 On 2/28/06, Scott Long wrote: > Maksim Yevmenkin wrote: [...] > >>Ultimately I would like to see this enabled by default so that > >>everything 'just works', but with a way to easily disable it in case > >>something goes wrong. Would that be possible? > > > > right now i can think of two ways to make it enabled by default: > > > > 1) add 'device kbdmux' to the kernel config (or even make it required) > > Could you add a check to the probe/attach routines of kbdmux so that it > could be disabled via a loader hint? I assume that there will only be > one instance of the kbdmux device, so this should be easy to do. > Something similar is possible with acpi, fwiw. sure. i can add check in kbdmux_probe(). > > 2) set kbdmux_load to "YES" somewhere in loader.* files (somewhat > > similar to acpi). > > Actually, acpi is much more evil. The loader probes the BIOS to see if > ACPI tables are present, and then sets the acpi_load variable based on > that. So no variables in loader.* are present in the default install. > If we wanted to add the kbdmux_load variable in the default system then > we will need to add /usr/src/sys/boot/forth/loader.conf, or add magic > to the installkernel target to handle it similar to device.hints. ok. i will add check for hints then. so, i guess, the plan is to add device kbdmux into default kernel config and use hints do enable/disable kbdmux, right? thanks, max