Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Sep 2014 06:46:44 GMT
From:      John-Mark Gurney <jmg@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 1200500 for review
Message-ID:  <201409190646.s8J6kiFA012987@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@1200500?ac=10

Change 1200500 by jmg@jmg_carbon2 on 2014/09/19 06:46:28

	fix up $Id$ to be $FreeBSD$
	
	I've confirmed with Shay that the code was broken, so no need to
	keep it around anymore...
	
	Sponsored by:	FreeBSD Foundation
	Sponsored by:	Rubicon Communications, LLC (Netgate)

Affected files ...

.. //depot/projects/opencrypto/sys/crypto/aesni/aesni_ghash.c#3 edit

Differences ...

==== //depot/projects/opencrypto/sys/crypto/aesni/aesni_ghash.c#3 (text+ko) ====

@@ -26,7 +26,7 @@
  * SUCH DAMAGE.
  *
  *
- *	$Id$
+ *	$FreeBSD$
  *
  */
 
@@ -658,12 +658,7 @@
 	X = _mm_shuffle_epi8(X, BSWAP_MASK);
 	T = _mm_xor_si128(X, T);
 
-#if 0
-	/* XXX - broken Intel code */
-	if (_mm_testz_si128(T, _mm_loadu_si128((__m128i*)tag)))
-#else
 	if (!m128icmp(T, _mm_loadu_si128((__m128i*)tag)))
-#endif
 		return 0; //in case the authentication failed
 
 	ctr1 = _mm_shuffle_epi8(Y, BSWAP_EPI64);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409190646.s8J6kiFA012987>