Date: Fri, 13 Sep 2019 14:05:43 +0000 From: Brooks Davis <brooks@freebsd.org> To: Mihir Luthra <luthramihir708@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: correct ways to get code reviewed Message-ID: <20190913140543.GC93439@spindle.one-eyed-alien.net> In-Reply-To: <CAEa=dYCAAXhq694pyzs5KgY1Wjdhg0Vbf9uVTyg9CGa_E92w3A@mail.gmail.com> References: <CAEa=dYCAAXhq694pyzs5KgY1Wjdhg0Vbf9uVTyg9CGa_E92w3A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--KFztAG8eRSV9hGtP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 13, 2019 at 11:49:23AM +0530, Mihir Luthra wrote: > Hi everyone, >=20 > I am a new contributor to FreeBSD projects. Recently I have started making > changes in the source code by working on project ipv6 userland cleanup [1= ]. > I did post one patch to phabrictor which got reviewed as well. >=20 > I had some queries in my mind on which I wanted some advice. > 1) Should I post another patch only after the first one has been approved > or is it better to keep posting patches irrespective of review status of > the first? It's fine to post multiple patches. If you have multiple patches that depend on each other you may find it useful to post both to let reviewers see the bigger picture. > 2) Should I ask commiters for review individually or should I post the li= nk > on the mailing lists? Or maybe should I simply wait for the patch to get > reviewed without informing anyone? Asking individual committers is a good approach if you can identify an active committers in the area. Mailing lists can also work. I don't recommend posting patching and hoping someone reviews them. That's all too likely to result in them being dropped. > 3) If the patch gets approved, do I need to submit a pul request on github > or is their some different procedure? If a patch is approved, you should ask the reviewer(s) to commit it. Can easily use "arc patch" to apply it and commit it. -- Brooks --KFztAG8eRSV9hGtP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJde6I2AAoJEKzQXbSebgfANTsH/i936fAJOUWM4tJRReB7hCl2 UGBsVwCdv1lVkS9W6ogMapzj+tglJqBVC60C+Jq/Qu8TpoSmPS6frcuSgZ6ulMyo uj7G0h6n+tqDAHJS5ZuyCiV/AD09BzOlEFHCwQkM9wNWRVlDVHjqL7CN3tTMTMhO Nib3tRwg9mO5ILo1k9Rt+gATJn+UzMNQ8FRAiXA2w9MjhKL0uGKPLXcQWUbcDcmS zOHDVes0f3TJa5dpcGqXmqndFeeJApqtN41VW2AKJ3Qh81kCZsOBzjsamXieeUiP XuZ0QtOjxNn/Df1BuInnTeAVpbC7BIP/3MgsJkpjYfrpL+ehbHI7Z79cAsS7HhA= =bk3w -----END PGP SIGNATURE----- --KFztAG8eRSV9hGtP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190913140543.GC93439>