Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Dec 2006 09:45:03 -0800
From:      Sam Leffler <sam@errno.com>
To:        Martin Blapp <mb@imp.ch>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern tty.c
Message-ID:  <4588251F.3040206@errno.com>
In-Reply-To: <20061219181505.L53548@godot.imp.ch>
References:  <200612191646.kBJGkEln071323@repoman.freebsd.org> <45881D46.8090201@errno.com> <20061219181505.L53548@godot.imp.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
Martin Blapp wrote:
> 
> Hi Sam,
> 
> I'll have got again a setup box in the next week and work hard
> with bde, gib and tegge to solve them. For RELENG_6_2 it's
> too late. I hope to get that small workaround again committed,
> but for more serios work we would have to delay 6.2 for half a
> year ;-)
> 
> The full tty locking stuff is also pendent, maybe I'll grab that
> and make it work. Unfortunatly this will open again a new 'can of worms':
> new races will appear.
> 
> Martin
> 
>>>   Modified files:
>>>     sys/kern             tty.c
>>>   Log:
>>>   Add the tp->t_refcnt validity check back. There are still some race
>>>   conditions where tp->t_refcnt can go to zero.
>>
>> Can you please identify those races?

That is not what I was asking for.  You said "there are races" but
didn't identify them.  It would be helpful to know what these races are
so someone other than you doesn't need to guess why you made this change.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4588251F.3040206>