From owner-cvs-all Mon Feb 24 1:37:11 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C162B37B401; Mon, 24 Feb 2003 01:37:09 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2924E43FCB; Mon, 24 Feb 2003 01:37:09 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id EEF4DAE165; Mon, 24 Feb 2003 01:37:08 -0800 (PST) Date: Mon, 24 Feb 2003 01:37:08 -0800 From: Alfred Perlstein To: phk@phk.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20030224093708.GM27224@elvis.mu.org> References: <20030224082427.GL27224@elvis.mu.org> <30346.1046075295@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <30346.1046075295@critter.freebsd.dk> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * phk@phk.freebsd.dk [030224 00:28] wrote: > In message <20030224082427.GL27224@elvis.mu.org>, Alfred Perlstein writes: > > >> It børks a diskless machine, I posted the details to current@ some days ago. > > > >No, I realized relatively quickly what had gone wrong once someone > >posted a backtrace, I think it was scott. > > > >I also explained to scott why the ordering is needed. Right now he > >has rebroken the mp safety of filedescs so instead of a problem that's > >quite easy to find we have broken code that's racey and can lead to > >crashes. > > Well, if given the choice between something which works most of the time > on all the machines, and something which breaks some of the machines > totally all of the time, I prefer the former until the true fix can > be found. I didn't offer nor care about the choice you're describing, except to note that the comment describing it sucks as much as the change itself. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message