Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jun 2015 17:38:46 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        Ed Maste <emaste@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, svn-src-vendor@FreeBSD.org
Subject:   Re: svn commit: r284412 - in vendor-sys/illumos/dist/uts/common/fs/zfs: . sys
Message-ID:  <20150615143846.GZ73119@FreeBSD.org>
In-Reply-To: <557ED7CC.7030002@FreeBSD.org>
References:  <201506151250.t5FCoifP019075@svn.freebsd.org> <CAPyFy2Cuo7mULXN6=9irUUSf3nXsqX8jjnTCYD4qzBMXPPO5Eg@mail.gmail.com> <557ECD22.8090402@FreeBSD.org> <CAPyFy2DOPg6KTLYv5MSRNuUHYL8FX=PrEdJzKC%2BY2nLVSU%2BU=g@mail.gmail.com> <557ED7CC.7030002@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 15, 2015 at 04:49:00PM +0300, Andriy Gapon wrote:
A> On 15/06/2015 16:42, Ed Maste wrote:
A> > On 15 June 2015 at 09:03, Andriy Gapon <avg@freebsd.org> wrote:
A> >>
A> >> I guess I could extend my script to expand 5911 to
A> >> https://www.illumos.org/issues/5911
A> > 
A> > Yeah, I think that would be useful -- although it's probably too long
A> > to go in the first line, then.
A> > 
A> > I guess the problem is that the upstream Illumos commits follow a
A> > certain convention, and that meaning/context is lost when they come
A> > into FreeBSD. Linking to the original issue should take care of that.
A> > 
A> 
A> Yes, indeed.  Regular ZFS/FreeBSD hackers are aware of the conventions and
A> places to look, but most of committers do not necessarily know of them.
A> 
A> So, this is the format that I will try use (using this commit as an example):
A> ========================================
A> 5911 ZFS "hangs" while deleting file
A> 
A> Reviewed by: Bayard Bell <buffer.g.overflow@gmail.com>
A> Reviewed by: Alek Pinchuk <alek@nexenta.com>
A> Reviewed by: Simon Klinkert <simon.klinkert@gmail.com>
A> Reviewed by: Dan McDonald <danmcd@omniti.com>
A> Approved by: Richard Lowe <richlowe@richlowe.net>
A> Author: Matthew Ahrens <mahrens@delphix.com>
A> 
A> illumos/illumos-gate@46e1baa6cf6d5432f5fd231bb588df8f9570c858
A> https://www.illumos.org/issues/5911
A> ========================================

Is it possible to expand your script to

fetch https://www.illumos.org/issues/$issue

into your text editor, so that you can quickly cut the issue text and
produce a paragraph describing the change?

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150615143846.GZ73119>