Date: Wed, 16 Jan 2002 13:58:43 +0000 From: Brian Somers <brian@freebsd-services.com> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/usr.sbin/ppp arp.c atm.c mp.c route.c server.c tcp.c udp.c Message-ID: <200201161358.g0GDwhL75791@hak.lan.Awfulhak.org> In-Reply-To: Message from Ruslan Ermilov <ru@FreeBSD.org> of "Wed, 16 Jan 2002 15:20:59 %2B0200." <20020116152059.C91833@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, Jan 16, 2002 at 05:15:47AM -0800, Brian Somers wrote: > > brian 2002/01/16 05:15:47 PST > > > > Modified files: > > usr.sbin/ppp arp.c atm.c mp.c route.c server.c tcp.c > > udp.c > > Log: > > socket's first argument is an address family, not a protocol family. > > > > Revision Changes Path > > 1.43 +2 -2 src/usr.sbin/ppp/arp.c > > 1.5 +2 -2 src/usr.sbin/ppp/atm.c > > 1.48 +2 -2 src/usr.sbin/ppp/mp.c > > 1.84 +2 -2 src/usr.sbin/ppp/route.c > > 1.39 +4 -4 src/usr.sbin/ppp/server.c > > 1.14 +2 -2 src/usr.sbin/ppp/tcp.c > > 1.14 +2 -2 src/usr.sbin/ppp/udp.c > > > Err, from the socket(2) manpage: > > : The domain parameter specifies a communications domain within which com- > : munication will take place; this selects the protocol family which should > : be used. These families are defined in the include file <sys/socket.h>. > : The currently understood formats are: > : > : PF_LOCAL Host-internal protocols, formerly called PF_UNIX, > : PF_UNIX Host-internal protocols, depreciated, use PF_LOCAL, > : PF_INET Internet version 4 protocols, > > sockaddr.sa_family OTOH should use AF_* constants. Bah! OpenBSD's socket(2) says: : The domain parameter specifies a communications domain within which com- : munication will take place; this selects the protocol family which should : be used. These families are defined in the include file <sys/socket.h>. : The currently understood formats are : : AF_UNIX (UNIX internal protocols), : AF_INET (ARPA Internet protocols), : AF_INET6 (ARPA IPv6 protocols), (I was on an OpenBSD box at the time). However, both man pages suggest that this is a protocol family, not an address family, so I think that as long as the PF_ constants remain in sys/socket.h, I agree with you. I'll switch to PF_ :) > Cheers, > -- > Ruslan Ermilov Oracle Developer/DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- Brian <brian@freebsd-services.com> <brian@Awfulhak.org> http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org> Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201161358.g0GDwhL75791>