Date: Mon, 21 Oct 2002 15:46:54 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: "Greg 'groggy' Lehey" <grog@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c machdep.c src/sys/i386/include reg.h Message-ID: <2141.1035208014@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 21 Oct 2002 15:54:47 %2B0930." <20021021062447.GA63728@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20021021062447.GA63728@wantadilla.lemis.com>, "Greg 'groggy' Lehey" writes: >On Sunday, 20 October 2002 at 13:48:56 -0700, Poul-Henning Kamp wrote: >> phk 2002/10/20 13:48:56 PDT >> >> Modified files: >> sys/i386/i386 db_trace.c machdep.c >> sys/i386/include reg.h >> Log: >> Change the definition of the debugging registers to be an array, so >> that we can index into it, rather than do pointer gymnastics on a >> structure containing 8 elements. >> >> Verified by: MD5 hash on the produced .o files. > >Not verified by: make world. > >This breaks world in a couple of places in lib/libc. I've added the >following to my local copy of the file: > >#define dr6 dr[6] >#define dr7 dr[7] > >It's not clear that this is the correct solution, so I haven't >committed it. It may actually be a good idea for those particular registers since that would allow us to keep the GDB file on the vendor-branch (Well, put it back using repo-surgery...) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2141.1035208014>