From owner-freebsd-stable@freebsd.org Mon Sep 12 13:45:39 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EB15BD7DEE for ; Mon, 12 Sep 2016 13:45:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 88D6DCF8 for ; Mon, 12 Sep 2016 13:45:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 849E7BD7DED; Mon, 12 Sep 2016 13:45:39 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84448BD7DEC for ; Mon, 12 Sep 2016 13:45:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id DA5A2CF7 for ; Mon, 12 Sep 2016 13:45:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA17770; Mon, 12 Sep 2016 16:45:30 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1bjRYA-0003Iy-Ia; Mon, 12 Sep 2016 16:45:30 +0300 Subject: Re: X2APIC support To: Slawa Olhovchenkov References: <20151212130615.GE70867@zxy.spb.ru> <20151212133513.GL82577@kib.kiev.ua> <20160901112724.GX88122@zxy.spb.ru> <20160901114500.GJ83214@kib.kiev.ua> <20160901121300.GZ88122@zxy.spb.ru> <4ba05c00-f737-f562-553d-a7fa59145768@FreeBSD.org> <20160904151415.GE83214@kib.kiev.ua> <20160904162926.GF83214@kib.kiev.ua> <358ed414-9da6-ac29-55fc-6d7be680c2ce@FreeBSD.org> <20160912093905.GP34394@zxy.spb.ru> Cc: Konstantin Belousov , stable@FreeBSD.org From: Andriy Gapon Message-ID: Date: Mon, 12 Sep 2016 16:44:09 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160912093905.GP34394@zxy.spb.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 13:45:39 -0000 On 12/09/2016 12:39, Slawa Olhovchenkov wrote: > On Sun, Sep 04, 2016 at 08:14:07PM +0300, Andriy Gapon wrote: > >> On 04/09/2016 19:29, Konstantin Belousov wrote: >>> This is possible, of course. But it would not affect "SMP: Added CPU ..." >>> lines. >> >> Well, looking at the code it seems that only if mptable is used, then those >> lines are expected to correctly identify a BSP. With MADT there is no >> information to identify the BSP and that is supposed to happen in cpu_mp_start(). >> >> >> static void >> madt_add_cpu(u_int acpi_id, u_int apic_id, u_int flags) >> { >> struct lapic_info *la; >> >> /* >> * The MADT does not include a BSP flag, so we have to let the >> * MP code figure out which CPU is the BSP on its own. >> */ >> ... >> >> In other words, those "SMP: Added CPU ..." are truly a cosmetic issue. >> And it's my guess (just a guess) that BSP LAPIC ID is incorrect in the >> problematic configuration. > > For next day or two I am have new server with same hardware before put > in prodution. > Can I do some test for you? > >From my earlier email: "my guess can be checked by adding a printf to cpu_mp_start() right after boot_cpu_id assignment". -- Andriy Gapon