From owner-cvs-all Tue Jan 16 17:38:29 2001 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 6210537B401; Tue, 16 Jan 2001 17:38:10 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f0H1cAI01265; Tue, 16 Jan 2001 17:38:10 -0800 (PST) Date: Tue, 16 Jan 2001 17:38:10 -0800 From: Alfred Perlstein To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Bosko Milekic Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <20010116173809.C7240@fw.wintelcom.net> References: <20010116171353.A7240@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Tue, Jan 16, 2001 at 05:24:37PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010116 17:24] wrote: > > > Your patch doesn't fix the deadlock, it only turns it into a panic. > > A panic is much easier to debug than a deadlock. We don't need to debug it, we know it's going to happen and why. :) > > > A fix would be to DROP_GIANT on entry into a driver, or make kmem_alloc > > not require Giant. > > The latter is preferable, but that would mean locking down vm. Are you > volunteering? :) Hmm, well, there's already a bunch of lockmgr locks protecting the map structures, I'm wondering if we need to lock down the entire thing, or only the map manipulation routines. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message