From owner-trustedbsd-cvs@FreeBSD.ORG  Sun Aug  6 11:01:38 2006
Return-Path: <owner-trustedbsd-cvs@FreeBSD.ORG>
X-Original-To: trustedbsd-cvs@freebsd.org
Delivered-To: trustedbsd-cvs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 975CD16A4DA
	for <trustedbsd-cvs@freebsd.org>; Sun,  6 Aug 2006 11:01:38 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1643243D53
	for <trustedbsd-cvs@freebsd.org>; Sun,  6 Aug 2006 11:01:38 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119])
	by cyrus.watson.org (Postfix) with ESMTP id 7969346CEB
	for <trustedbsd-cvs@trustedbsd.org>;
	Sun,  6 Aug 2006 07:01:37 -0400 (EDT)
Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])
	by mx2.freebsd.org (Postfix) with ESMTP id CB703558FA;
	Sun,  6 Aug 2006 11:01:35 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C897E16A4E6; Sun,  6 Aug 2006 11:01:35 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A3ECD16A4DD
	for <perforce@freebsd.org>; Sun,  6 Aug 2006 11:01:35 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5290843D45
	for <perforce@freebsd.org>; Sun,  6 Aug 2006 11:01:35 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k76B1Z1S041169
	for <perforce@freebsd.org>; Sun, 6 Aug 2006 11:01:35 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k76B1ZBJ041166
	for perforce@freebsd.org; Sun, 6 Aug 2006 11:01:35 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sun, 6 Aug 2006 11:01:35 GMT
Message-Id: <200608061101.k76B1ZBJ041166@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 103326 for review
X-BeenThere: trustedbsd-cvs@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD CVS and Perforce commit message list
	<trustedbsd-cvs.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>, 
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-cvs>
List-Post: <mailto:trustedbsd-cvs@FreeBSD.org>
List-Help: <mailto:trustedbsd-cvs-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>,
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Aug 2006 11:01:38 -0000

http://perforce.freebsd.org/chv.cgi?CH=103326

Change 103326 by rwatson@rwatson_zoo on 2006/08/06 11:01:27

	In FreeBSD, assert the vnode lock when accessing MAC labels on
	vnodes.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/mac/mac_audit.c#5 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/mac/mac_audit.c#5 (text+ko) ====

@@ -71,6 +71,8 @@
 	int error;
 	struct label *vl;
 
+	ASSERT_VOP_LOCKED(vp, "mac_check_system_auditctl");
+
 	vl = (vp != NULL) ? vp->v_label : NULL;
 
 	MAC_CHECK(check_system_auditctl, cred, vp, vl);