Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Jul 2008 23:32:44 GMT
From:      "Pedro F. Giffuni" <giffunip@tutopia.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/125846: Fix for science/silo
Message-ID:  <200807212332.m6LNWiD4029264@www.freebsd.org>
Resent-Message-ID: <200807212340.m6LNe1wh002478@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         125846
>Category:       ports
>Synopsis:       Fix for science/silo
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 21 23:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Pedro F. Giffuni
>Release:        6.3-Release
>Organization:
>Environment:
FreeBSD kakumen.cable.net.co 6.3-RELEASE FreeBSD 6.3-RELEASE #10: Sat Jan 19 01:13:55 COT 2008     root@kakumen.cable.net.co:/usr/src/sys/amd64/compile/SMP  amd64

>Description:
- Turn off the python module as it causes breakage in the build cluster.
- While here, rename the BROWSER option to SILEXB to avoid confusion.
- No version bump since no package has been built.
>How-To-Repeat:
- Pointyhat is not picking up USE_PYTHON because it is defined after bsd.port.pre.mk
- portlint will complain if we try to use WITH_PYTHON before bsd.port.mk so either way we lose.
- Thankfully I don't need the python module for my project, and people wanting it are like to know they should install it.
>Fix:
diff -ruN silo.orig/Makefile silo/Makefile
--- silo.orig/Makefile	2008-07-21 17:45:44.000000000 -0500
+++ silo/Makefile	2008-07-21 18:31:15.000000000 -0500
@@ -28,16 +28,17 @@
 USE_QT_VER=	3
 QT_COMPONENTS=	moc uic
 
-OPTIONS=	PYTHON	"Enable Python Module" On \
+OPTIONS=	PYTHON	"Enable Python Module" Off \
 		HDF5	"Enable HDF5 Driver" Off \
-		BROWSER	"Enable Silex Browser" Off \
+		SILEXB	"Enable Silex Browser" Off \
 		FORTRAN "Compile Fortran interface" Off \
 		OPTIMIZATION "Enable extra optimizations" On
 
+USE_PYTHON=	yes
+
 .include <bsd.port.pre.mk>
 
 .ifdef WITH_PYTHON
-USE_PYTHON=	yes
 CONFIGURE_ARGS+=	--enable-pythonmodule
 PLIST_SUB+=	WITH_PYTHON=""
 .else
@@ -54,11 +55,11 @@
 PLIST_SUB+=	WITH_NCDF=""
 .endif
 
-.ifdef WITH_BROWSER
+.ifdef WITH_SILEXB
 CONFIGURE_ARGS+=	--enable-silex
-PLIST_SUB+=	WITH_BROWSER=""
+PLIST_SUB+=	WITH_SILEXB=""
 .else
-PLIST_SUB+=	WITH_BROWSER="@comment "
+PLIST_SUB+=	WITH_SILEXB="@comment "
 .endif
 
 .ifdef WITH_FORTRAN
diff -ruN silo.orig/pkg-plist silo/pkg-plist
--- silo.orig/pkg-plist	2008-07-21 17:45:44.000000000 -0500
+++ silo/pkg-plist	2008-07-21 18:30:43.000000000 -0500
@@ -1,4 +1,4 @@
-%%WITH_BROWSER%%bin/browser
+%%WITH_SILEXB%%bin/browser
 bin/silodiff
 bin/silex
 bin/silock


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807212332.m6LNWiD4029264>