Date: Fri, 18 Aug 2006 18:33:11 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Dag-Erling Sm?rgrav <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr Message-ID: <20060818143310.GA14203@comp.chem.msu.su> In-Reply-To: <86ejvet9m6.fsf@xps.des.no> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 18, 2006 at 04:13:37PM +0200, Dag-Erling Sm?rgrav wrote: > Yar Tikhiy <yar@FreeBSD.org> writes: > > Log: > > The ps(1) command is unfriendly to scripts by default because > > it limits the width of its output to the value of $COLUMNS, or > > what TIOCGWINSZ reports, or 79 columns. We should specify -ww > > to ps(1) so that it removes the limit and prints lines in full. > > Otherwise very long command pathnames could be mishandled, e.g., > > by _find_processes(). > > or perhaps _find_processes() should use pgrep(1) instead of ps(1). I considered that but had to stick to ps(1) because pgrep was in /usr/bin while ps was in /bin. The use of /usr/bin tools should be very limited in rc.subr(8). OTOH, pgrep uses /lib libs only, which makes it possible to transfer pgrep+pkill to /bin if we can stand the growth of / by some 50 kbytes. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060818143310.GA14203>