From owner-cvs-all Fri Aug 18 1:52:34 2000 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 32C2437B422; Fri, 18 Aug 2000 01:52:27 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.9.3/1.13) id LAA23155; Fri, 18 Aug 2000 11:51:46 +0300 (EEST) Date: Fri, 18 Aug 2000 11:51:46 +0300 From: Ruslan Ermilov To: "Andrey A. Chernov" Cc: Warner Losh , Brian Fundakowski Feldman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile config.h job.c main.c Message-ID: <20000818115146.A19019@sunbay.com> References: <20000817191010.A83092@nagual.pp.ru> <20000817073828.A78992@nagual.pp.ru> <20000817191010.A83092@nagual.pp.ru> <200008171550.JAA15746@billy-club.village.org> <20000817202053.A83828@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <20000817202053.A83828@nagual.pp.ru>; from ache@nagual.pp.ru on Thu, Aug 17, 2000 at 08:20:53PM +0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Aug 17, 2000 at 08:20:53PM +0400, Andrey A. Chernov wrote: > On Thu, Aug 17, 2000 at 09:50:34AM -0600, Warner Losh wrote: > > In message <20000817191010.A83092@nagual.pp.ru> "Andrey A. Chernov" writes: > > : Do we want another non-standard feature to be different from the rest of > > : the world? F.e. GNU make use ${SHELL} for this purpose too. > > : > > : What is exactly wrong with ${SHELL} variable? IMHO this worth fixing and > > : not worth yet another incompatibility. > > > > But the original commit message said that csh doesn't work with make, > > and when I login with a csh, I get SHELL=/bin/csh > > With GNU/SysV make style this is desired effect, many makefiles started > with > SHELL=/bin/sh > because of it. > But as Bruce says, this is not a case for BSD make which must use .SHELL > instead as documented. In either case no MAKE_SHELL. > Did you look over the actual change? New ${MAKE_SHELL} is not a run-time variable, it is a compile-time one and only affects the selection of the default (compiled in) shell. You can always use run-time .SHELL target. Note that .SHELL only works in -j mode. -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message