From owner-freebsd-bugs@FreeBSD.ORG Sat Jan 17 05:40:22 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 196B316A4CE for ; Sat, 17 Jan 2004 05:40:22 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F09EC43D45 for ; Sat, 17 Jan 2004 05:40:19 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0HDeJFR059922 for ; Sat, 17 Jan 2004 05:40:19 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0HDeJKm059921; Sat, 17 Jan 2004 05:40:19 -0800 (PST) (envelope-from gnats) Resent-Date: Sat, 17 Jan 2004 05:40:19 -0800 (PST) Resent-Message-Id: <200401171340.i0HDeJKm059921@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alex Popa Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85CFD16A4CE for ; Sat, 17 Jan 2004 05:36:32 -0800 (PST) Received: from ldc.ro (ldc-gw.rdsnet.ro [213.157.163.8]) by mx1.FreeBSD.org (Postfix) with SMTP id DC3FA43D53 for ; Sat, 17 Jan 2004 05:36:30 -0800 (PST) (envelope-from razor@ldc.ro) Received: (qmail 22594 invoked by uid 666); 17 Jan 2004 13:36:29 -0000 Message-Id: <20040117133629.22552.qmail@ldc.ro> Date: 17 Jan 2004 13:36:29 -0000 From: Alex Popa To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/61473: ffsinfo *appends* its output to an existing outfile X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Alex Popa List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2004 13:40:22 -0000 >Number: 61473 >Category: bin >Synopsis: ffsinfo *appends* its output to an existing outfile >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 17 05:40:19 PST 2004 >Closed-Date: >Last-Modified: >Originator: Alex Popa >Release: FreeBSD 4.9-STABLE i386 >Organization: >Environment: System: FreeBSD ns.ldc.ro 4.9-STABLE FreeBSD 4.9-STABLE #0: Fri Jan 2 21:44:54 EET 2004 root@ns.ldc.ro:/usr/obj/usr/src/sys/NS i386 >Description: The ffsinfo manpage mentions the output is "generated into" the file outfile , but the code (namely dbg_open in /usr/src/sbin/growfs/debug.c) actually APPENDS the output to said file. The manpage should match the code, and possibly warn people to delete the outfile before running ffsinfo again. >How-To-Repeat: Run ffsinfo on two different filesystems without deleting the outfile. At first look, it seems the outfile has not changed (actually the info on the second filesystem is there, but after the info about the first one ends. OR run ffsinfo twice, and notice the increasing output size: ns# rm /var/tmp/ffsinfo; \ ffsinfo /dev/ad0s1a; du /var/tmp/ffsinfo; \ ffsinfo /dev/ad0s1a; du /var/tmp/ffsinfo 92 /var/tmp/ffsinfo 182 /var/tmp/ffsinfo >Fix: Apply the following patch to /usr/src/sbin/ffsinfo/ffsinfo.8: --- ffsinfo.8.orig Sat Jan 17 15:34:21 2004 +++ ffsinfo.8 Sat Jan 17 15:34:36 2004 @@ -58,7 +58,7 @@ .Xr dumpfs 8 utility. .Pp -The output is generated into the file +The output is appended to the file .Pa outfile . Also expect the output file to be rather large. Up to 2 percent of the size of the specified file system is not uncommon. >Release-Note: >Audit-Trail: >Unformatted: