From owner-cvs-src@FreeBSD.ORG Sat Dec 17 20:13:18 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E90416A41F; Sat, 17 Dec 2005 20:13:18 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEE4643D68; Sat, 17 Dec 2005 20:12:59 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jBHKCwuY035424; Sat, 17 Dec 2005 13:12:58 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43A4714C.1080202@samsco.org> Date: Sat, 17 Dec 2005 13:13:00 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <43A547F2.2090401@root.org> In-Reply-To: <43A547F2.2090401@root.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=3.8 tests=ALL_TRUSTED, SUBJ_HAS_SPACES autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 20:13:18 -0000 Nate Lawson wrote: > Scott Long wrote: > >> Nate Lawson wrote: >> >> >>> njl 2005-12-17 03:57:10 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/sys ktr.h sys/kern kern_clock.c >>> kern_switch.c Log: >>> Clean up unused or poorly utilized KTR values. Remove KTR_FS, >>> KTR_KGDB, >>> and KTR_IO as they were never used. Remove KTR_CLK since it was only >>> used for hardclock firing and use KTR_INTR there instead. Remove >>> KTR_CRITICAL since it was only used for crit enter/exit and use >>> KTR_CONTENTION instead. >>> >>> Revision Changes Path >>> 1.183 +1 -1 src/sys/kern/kern_clock.c >>> 1.118 +2 -2 src/sys/kern/kern_switch.c >>> 1.35 +12 -12 src/sys/sys/ktr.h >> >> >> >> Um, I was using KTR_CRITICAL for schedgraph. It was actually quite >> useful. Compressing the option space only makes the options less >> useful. Surely there has to be a better solution. Or, at least you >> could call for comments before you alter this stuff. > > > You didn't speak up about that in the previous discussion on arch@, > starting 10/31/2005. The only comment was jhb@ saying it was not useful > alone, and he's the only one doing work on critical sections lately. Um, cut me a little slack for WORKING ON A DAMN RELEASE that week. > > If you can think of another use for this besides one event (enter/exit), > feel free to add it back. Or, consider adding KTR_SUBSYS as a one-off > use like KTR_DEV is for other parts of the system. KTR_CRITICAL would > be conditionally defined as KTR_SUBSYS when needed. > It may only be a single event pair, but they are fired quite often. Cluttering up the option with more events only makes it harder to collect a useful amount of data. Btw, fix your system clock. Scott