Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Aug 2019 10:37:21 +0200
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        =?iso-8859-1?Q?Vin=EDcius?= Zavam <egypcio@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r508711 - in head/devel: . go-bindata-assetfs
Message-ID:  <20190812083721.GA27681@urd.tobik.me>
In-Reply-To: <201908120815.x7C8F6n0075704@repo.freebsd.org>
References:  <201908120815.x7C8F6n0075704@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 12, 2019 at 08:15:06AM +0000, Vin=EDcius Zavam wrote:
> Author: egypcio
> Date: Mon Aug 12 08:15:05 2019
> New Revision: 508711
> URL: https://svnweb.freebsd.org/changeset/ports/508711
>=20
> Log:
>   [NEW] devel/go-bindata-assetfs: serves embedded files with net/http sup=
port
>  =20
>     go-bindata-assetfs serves embedded files from go-bindata with Go's
>     net/http support, allowing packages to serve http static content.
>  =20
>     WWW: https://github.com/elazarl/go-bindata-assetfs
>=20

This does not make proper use of USES=3Dgo.  The custom targets are
not needed:

Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Makefile	(revision 508711)
+++ Makefile	(working copy)
@@ -12,22 +12,14 @@
 RUN_DEPENDS=3D	go-bindata>=3D0:devel/go-bindata
=20
 USES=3D		go
-USE_GITHUB=3D	nodefault
+USE_GITHUB=3D	yes
+GH_ACCOUNT=3D	elazarl
+GH_TAGNAME=3D	38087fe
+GH_TUPLE=3D	golang:net:ca1201d:golang_net/src/golang.org/x/net \
+		golang:sys:51ab0e2:golang_sys/src/golang.org/x/sys \
=20
-GO_PKGNAME=3D	github.com/elazarl/${PORTNAME}/${PORTNAME}
-GH_TUPLE=3D	elazarl:${PORTNAME}:38087fe:elazarl_gbd/github.com/elazarl/${P=
ORTNAME} \
-		golang:net:ca1201d:golang_net/golang.org/x/net \
-		golang:sys:51ab0e2:golang_sys/golang.org/x/sys \
+GO_TARGET=3D	./${PORTNAME}
=20
 PLIST_FILES=3D	bin/${PORTNAME}
=20
-do-build:
-	@cd ${WRKSRC} && \
-	  ${RLN} ${WRKSRC} src && \
-	  ${SETENV} ${MAKE_ENV} ${GO_ENV} GOPATH=3D${WRKSRC} ${GO_CMD} \
-	  build ${GO_BUILDFLAGS} -o bin/${PORTNAME} ${GO_PKGNAME}
-
-do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/bin/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
-
 .include <bsd.port.mk>
Index: distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- distinfo	(revision 508711)
+++ distinfo	(working copy)
@@ -1,6 +1,6 @@
-TIMESTAMP =3D 1565348812
-SHA256 (elazarl-go-bindata-assetfs-38087fe_GH0.tar.gz) =3D b08df214d8cc9e4=
004fc399414cbe18de80f666a38ad49d79c34f7378e2f13c8
-SIZE (elazarl-go-bindata-assetfs-38087fe_GH0.tar.gz) =3D 3988
+TIMESTAMP =3D 1565598186
+SHA256 (elazarl-go-bindata-assetfs-g20180223-38087fe_GH0.tar.gz) =3D b08df=
214d8cc9e4004fc399414cbe18de80f666a38ad49d79c34f7378e2f13c8
+SIZE (elazarl-go-bindata-assetfs-g20180223-38087fe_GH0.tar.gz) =3D 3988
 SHA256 (golang-net-ca1201d_GH0.tar.gz) =3D d70d188cea7e5c254eac97d3a63e6b9=
59b18c159cb0393cd38e01277fe377eff
 SIZE (golang-net-ca1201d_GH0.tar.gz) =3D 1099085
 SHA256 (golang-sys-51ab0e2_GH0.tar.gz) =3D dc0fffb69ff5a4e83b3bf3d4817b8ca=
cfa85f36ab93855030e3ce8937cc89b88


--+HP7ph2BbKc20aGI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl1RJTpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2EznAf+ImWYL+A7PrNu70gLu9XUUYojxfAbQdGl3mttWgvVsSgCMDVFZp0JnfVC
bCMII/ySgL474Td0XN5FZ8lkA0JumfPjon5h+/A00mlJCwJgH7rFpHhp7LE78xRV
zWiI3DQZyjgddDdaRpEdch9Oynd2wLYk/eKJaTQbtmdyZjxTPPidGnvUK3eP5r3W
Gahg3k90kLDIkk5Jmq3yTYZDwUooagHLqIZaDQ+S9ntfNY7zdKFuNWZudpc/gDhT
iH86/FYyuCBwN0c73kG/OGkfovcmkzXxhWHjP8++fMO17Ksf0ys8ER+fE8zzOvgQ
IKv6OL6//Q13a2MkztzgJYkZKDG96A==
=DEUy
-----END PGP SIGNATURE-----

--+HP7ph2BbKc20aGI--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190812083721.GA27681>