From owner-freebsd-ports-bugs@freebsd.org Mon Oct 1 23:37:27 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3ACF10AD694 for ; Mon, 1 Oct 2018 23:37:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4C7D471AC9 for ; Mon, 1 Oct 2018 23:37:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0DD7B10AD693; Mon, 1 Oct 2018 23:37:27 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F093810AD692 for ; Mon, 1 Oct 2018 23:37:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7AAFB71AC8 for ; Mon, 1 Oct 2018 23:37:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D6663134A8 for ; Mon, 1 Oct 2018 23:37:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w91NbP2q051673 for ; Mon, 1 Oct 2018 23:37:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w91NbPRe051672 for ports-bugs@FreeBSD.org; Mon, 1 Oct 2018 23:37:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231870] ports-mgmt/portint: Bogus warnings about extra items placed in the USES/USE_x section Date: Mon, 01 Oct 2018 23:37:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 23:37:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231870 Bug ID: 231870 Summary: ports-mgmt/portint: Bogus warnings about extra items placed in the USES/USE_x section Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: tobik@freebsd.org With something like (see editors/ghostwriter for an example port) USES=3D ... USE_GITHUB=3D yes GH_ACCOUNT=3D blabla portlint -AC wrongly complains WARN: Makefile: extra item placed in the USES/USE_x section, for exampl= e, "GH_ACCOUNT". 0 fatal errors and 1 warning found. This is contrary to what's suggested in the Porter's Handbook [1] where it says Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it. Also see the example Makefile at [2]. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.ht= ml [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.h= tml --=20 You are receiving this mail because: You are the assignee for the bug.=