Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Mar 2006 13:38:25 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Sam Leffler <sam@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/release Makefile
Message-ID:  <200603091338.28350.jhb@freebsd.org>
In-Reply-To: <200603091335.23964.jhb@freebsd.org>
References:  <200603091711.k29HBI49013996@repoman.freebsd.org> <200603091335.23964.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 09 March 2006 13:35, John Baldwin wrote:
> On Thursday 09 March 2006 12:11, Sam Leffler wrote:
> > sam         2006-03-09 17:11:18 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     release              Makefile 
> >   Log:
> >   handle KERNELS as before
> >   
> >   Submitted by:   ru, andrew
> 
> Does this actually work though?  I thought if you did
> 
> make KERNELS=FOO release
> 
> That any KERNELS?= or KERNELS+= lines would be ignored and the
> value on the command line would take precedence.  Alternatively,
> if you do 'env KERNELS=foo make release' then KERNELS+= would
> work.

nm, I see it does work because the += is only really used inside
the nested make.  Note that in the default case you are going to
build the kernels twice though I think. :)  Because KERNELS will be
set to 'GENERIC SMP' in the outer make (and thus set that way in
the 'mk' script) and then the 'make doRELEASE' will add 'GENERIC SMP'
to it again.
 
-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603091338.28350.jhb>