From owner-svn-src-all@FreeBSD.ORG Sun Dec 28 19:32:09 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E61F1065675 for ; Sun, 28 Dec 2008 19:32:09 +0000 (UTC) (envelope-from stas@SpringDaemons.com) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 038858FC0C for ; Sun, 28 Dec 2008 19:32:09 +0000 (UTC) (envelope-from stas@SpringDaemons.com) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id 5D6DD8FC4F for ; Sun, 28 Dec 2008 22:20:12 +0300 (MSK) Received: from sputnik.SpringDaemons.com (unknown [195.161.8.1]) by mx0.deglitch.com (Postfix) with ESMTPA id 7D9F08FC18; Sun, 28 Dec 2008 22:20:08 +0300 (MSK) Received: by sputnik.SpringDaemons.com (Postfix, from userid 1024) id EA98CB86F; Sun, 28 Dec 2008 22:30:45 +0300 (MSK) Date: Sun, 28 Dec 2008 22:30:39 +0300 From: Stanislav Sedov To: Andrew Thompson Message-Id: <20081228223039.cf28e3e2.stas@FreeBSD.org> In-Reply-To: <20081228045055.GA81182@citylink.fud.org.nz> References: <200812272048.mBRKmBKo082102@svn.freebsd.org> <20081228045055.GA81182@citylink.fud.org.nz> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprin: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Sun Dec 28 22:20:12 2008 X-DSPAM-Confidence: 1.0000 X-DSPAM-Improbability: 1 in 98689409 chance of being spam X-DSPAM-Probability: 0.0023 X-DSPAM-Signature: 4957d16c967001291218750 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186529 - head/sys/dev/acpi_support X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2008 19:32:09 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sat, 27 Dec 2008 20:50:55 -0800 Andrew Thompson mentioned: > On Sat, Dec 27, 2008 at 08:48:11PM +0000, Stanislav Sedov wrote: > > Author: stas > > Date: Sat Dec 27 20:48:11 2008 > > New Revision: 186529 > > URL: http://svn.freebsd.org/changeset/base/186529 > > > > Log: > > - Fix incorrect array declaration that was causing the stack overflow > > on some (most?) Asus laptops. > > > > Discussed with: rpaulo > > Approved by: kib (mentor) > > MFC after: 2 weeks > > > > Modified: > > head/sys/dev/acpi_support/acpi_asus.c > > > > Modified: head/sys/dev/acpi_support/acpi_asus.c > > ============================================================================== > > --- head/sys/dev/acpi_support/acpi_asus.c Sat Dec 27 20:37:53 2008 (r186528) > > +++ head/sys/dev/acpi_support/acpi_asus.c Sat Dec 27 20:48:11 2008 (r186529) > > @@ -976,7 +976,7 @@ acpi_asus_sysctl_set(struct acpi_asus_so > > { > > ACPI_STATUS status = AE_OK; > > ACPI_OBJECT_LIST acpiargs; > > - ACPI_OBJECT acpiarg[0]; > > + ACPI_OBJECT acpiarg[1]; > > > > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > > ACPI_SERIAL_ASSERT(asus); > > Thanks! I have had panics that I think are related to this. > I wonder how does gcc allowed this. It emits warnings only in pedantic mode which we cannot use to compile kernel with. Coverity is also calm about this issue. - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAklX0+UACgkQK/VZk+smlYEhJQCfc1cQKsaC1WufslPzh6A2Ys4f V9gAn0ctgYE++vyx/6dVJWI0EEYm6H0a =G9UK -----END PGP SIGNATURE----- !DSPAM:4957d16c967001291218750!