Date: Wed, 20 Jun 2001 15:10:43 -0700 From: Jordan Hubbard <jkh@osd.bsdi.com> To: bright@sneakerz.org Cc: bmilekic@technokratis.com, bmilekic@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c Message-ID: <20010620151043X.jkh@osd.bsdi.com> In-Reply-To: <20010620170145.N4543@sneakerz.org> References: <20010620162727.K4543@sneakerz.org> <20010620174149.A36453@technokratis.com> <20010620170145.N4543@sneakerz.org>
next in thread | previous in thread | raw e-mail | index | archive | help
To be fair to Bosko, what it looks like he's saying is that there's no reason to pass _any_ value to it since only zero is allowed and it doesn't do anything different if you pass a difference value. That would mean that people *can't* "rely on m_devget doing the wrong thing" because m_devget is currently capable of doing only one thing, regardless of what you pass to it, in any case. - Jordan From: Alfred Perlstein <bright@sneakerz.org> Subject: Re: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c Date: Wed, 20 Jun 2001 17:01:45 -0500 > * Bosko Milekic <bmilekic@technokratis.com> [010620 16:41] wrote: > > > > Argh! *Nobody* is going to be using that offset. It's wrong and it's > > from the pre-1995 era. All people may do is pass 0 to it anyway, in which the > > behavior won't change from the previous. > > But if it makes you feel so much better to have a broken function sit > > around -STABLE then fine, I just won't MFC it at all. And I'm not going to > > bother doing it later when someone complains that `offset' is not working > > as they expect it to. > > if... anyone passing something else than 0 to m_devget in -stable will > cause a panic() then go ahead, otherwise don't change the interface. > people accidentally relying on m_devget doing the wrong thing will have > quite a painful time trying to track it down if the behavior changes. > > -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010620151043X.jkh>