From owner-freebsd-net@FreeBSD.ORG Tue Aug 26 18:09:24 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7E616F59 for ; Tue, 26 Aug 2014 18:09:24 +0000 (UTC) Received: from mail-qg0-x22f.google.com (mail-qg0-x22f.google.com [IPv6:2607:f8b0:400d:c04::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D1663538 for ; Tue, 26 Aug 2014 18:09:24 +0000 (UTC) Received: by mail-qg0-f47.google.com with SMTP id i50so14962953qgf.6 for ; Tue, 26 Aug 2014 11:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=ILQjPyBnbae1ICtWMUYBYJwRp3ScvVl/KuLSJbqc650=; b=Y/VACREbHdeI15X0534LSFVvPzkWp+C3nqa/gMz7Z8S5KtQTvTtrVJrCGjP9M8CHxD t/sRAErF9tV6GtE77/spomQwbaJjUScnuyzEvf191fn/p45u1Sa0ofZBQUhtaKt/RaKx c9tuGb/3TVHvaThFN7bPh2P8GUEfUTy6TY3arlcM2azbyJ819xExu8YUmF3vdYh/Rgxx 2q5bPHuSPRPqJiYlZu0kG3XI2L1xjljv/iJVZCZvnLW3gASkSO911DfXOZle9ZBo0KLU RGFLPrnGMmRsFSDsrWw1ZIUYMQEP8BTEDyM9nql0VySMxB15oQqj7dixzDB+jkUAifHI VzNQ== MIME-Version: 1.0 X-Received: by 10.140.19.201 with SMTP id 67mr45383671qgh.28.1409076563211; Tue, 26 Aug 2014 11:09:23 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Tue, 26 Aug 2014 11:09:23 -0700 (PDT) In-Reply-To: <20140826145517.GD12732@gmail.com> References: <259C9434-C6FE-42EA-823D-ECB024DBF3D7@netapp.com> <814E0886-1B6B-4316-8BAB-684DAFDE1983@netapp.com> <20140826145517.GD12732@gmail.com> Date: Tue, 26 Aug 2014 11:09:23 -0700 X-Google-Sender-Auth: fWpJ0TsVI0gCntOpumvO2RECkCg Message-ID: Subject: Re: Patches for RFC6937 and draft-ietf-tcpm-newcwv-00 From: Adrian Chadd To: Tom Jones Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Net , "Eggert, Lars" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 18:09:24 -0000 Hi! I'm going to merge Tom's work in a week unless someone gives me a really good reason not to. I think there's been enough work and discussion about it since the first post from Lars in Feburary and enough review opportunity. -a On 26 August 2014 07:55, Tom Jones wrote: > On Tue, Aug 26, 2014 at 02:43:49PM +0000, Eggert, Lars wrote: >> Hi, >> >> the newcwv patch is probably stale now with Tom Jones' recent patch base= d on >> a more up-to-date version of the Internet-Draft, but the PRR patch shoul= d >> still be useful? > > My newcwv patch is much more up to date than Aris's, but it is slightly > different in implementation. I have had a few suggestions from Adrian, bu= t he > couldn't comment on how it relates to the tcp internals. > > There is a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191520 > > The biggest difference in structure between mine and Aris's patch is the = use of > tcp timers. It would be good to hear if my approach or Aris's is prefered= . > >> On 2014-6-19, at 23:35, George Neville-Neil wrote= : >> >> > On 4 Feb 2014, at 1:38, Eggert, Lars wrote: >> > >> >> Hi, >> >> >> >> below are two patches that implement RFC6937 ("Proportional Rate Redu= ction for TCP") and draft-ietf-tcpm-newcwv-00 ("Updating TCP to support Rat= e-Limited Traffic"). They were done by Aris Angelogiannopoulos for his MS t= hesis, which is at https://eggert.org/students/angelogiannopoulos-thesis.pd= f. >> >> >> >> The patches should apply to -CURRENT as of Sep 17, 2013. (Sorry for t= he delay in sending them, we'd been trying to get some feedback from commit= ters first, without luck.) >> >> >> >> Please note that newcwv is still a work in progress in the IETF, and = the patch has some limitations with regards to the "pipeACK Sampling Period= " mentioned in the Internet-Draft. Aris says this in his thesis about what = exactly he implemented: >> >> >> >> "The second implementation choice, is in regards with the measurement= of pipeACK. This variable is the most important introduced by the method a= nd is used to compute the phase that the sender currently lies in. In order= to compute pipeACK the approach suggested by the Internet Draft (ID) is fo= llowed [ncwv]. During initialization, pipeACK is set to the maximum possibl= e value. A helper variable prevHighACK is introduced that is initialized to= the initial sequence number (iss). prevHighACK holds the value of the high= est acknowledged byte so far. pipeACK is measured once per RTT meaning that= when an ACK covering prevHighACK is received, pipeACK becomes the differen= ce between the current ACK and prevHighACK. This is called a pipeACK sample= . A newer version of the draft suggests that multiple pipeACK samples can = be used during the pipeACK sampling period." >> >> >> >> Lars >> >> >> >> >> >> [prr.patch] >> >> >> >> [newcwv.patch] >> > >> > Apologies for not looking at this as yet. It is now closer to the top= of my list. >> > >> > Best, >> > George >> > > > > -- > Tom > @adventureloop > adventurist.me > > :wq > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"