From owner-freebsd-current Fri Jan 3 9: 6:31 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0535037B401 for ; Fri, 3 Jan 2003 09:06:30 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BA7043EC2 for ; Fri, 3 Jan 2003 09:06:29 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h03GnaF4026834; Fri, 3 Jan 2003 17:49:36 +0100 (CET) (envelope-from phk@freebsd.org) To: Takahashi Yoshihiro Cc: current@freebsd.org Subject: Re: buildworld trouble: multiple struct dos_partition. From: phk@freebsd.org In-Reply-To: Your message of "Sat, 04 Jan 2003 01:13:05 +0900." <20030104.011305.74720364.nyan@jp.FreeBSD.org> Date: Fri, 03 Jan 2003 17:49:36 +0100 Message-ID: <26833.1041612576@critter.freebsd.dk> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030104.011305.74720364.nyan@jp.FreeBSD.org>, Takahashi Yoshihiro writes: >In article <10926.1041590588@critter.freebsd.dk> >Poul-Henning Kamp writes: > >> I think you need to either #ifdef something here (and there may be >> more some similar code in places like truss or the debugger) or >> alternatively rename the structure to "pc98_partition" or similar. > >I think that the name "dos_partition" is not suitable for both i386 >and pc98. I wonder what does "dos" mean here. For example, it should >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, >respectively. You are correct in principle. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message