From owner-freebsd-acpi@FreeBSD.ORG Sat Apr 18 16:28:34 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9002A106568A; Sat, 18 Apr 2009 16:28:34 +0000 (UTC) (envelope-from nate@root.org) Received: from nlpi001.prodigy.net (nlpi001.sbcis.sbc.com [207.115.36.30]) by mx1.freebsd.org (Postfix) with ESMTP id 5E90C8FC13; Sat, 18 Apr 2009 16:28:34 +0000 (UTC) (envelope-from nate@root.org) Received: from [10.0.5.18] (ppp-71-139-8-80.dsl.snfc21.pacbell.net [71.139.8.80]) (authenticated bits=0) by nlpi001.prodigy.net (8.13.8 smtpauth/dk/map_regex/8.13.8) with ESMTP id n3IGSWKm021485; Sat, 18 Apr 2009 11:28:32 -0500 Message-ID: <49E9FFB0.6090707@root.org> Date: Sat, 18 Apr 2009 09:28:32 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: freebsd-acpi@freebsd.org References: <49DB639A.4090504@icyb.net.ua> <49DCF5C2.60805@root.org> <49DDF906.8090400@icyb.net.ua> <49DF3CA4.1090309@freebsd.org> <49E4B2A7.3020302@freebsd.org> <49E61986.7040709@root.org> <49E8AED0.1090008@freebsd.org> <20090418125806.2a48b0a8@fabiankeil.de> In-Reply-To: <20090418125806.2a48b0a8@fabiankeil.de> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andriy Gapon Subject: Re: run resume code only for S1-S4 states X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2009 16:28:36 -0000 Fabian Keil wrote: > Andriy Gapon wrote: > >> An updated version of the patch, the only difference is: do-while(0) is gone, >> breaks are replaces with gotos, indentation is reduced. >> >> Per Nate's request I am calling for people with SMP systems to test if powering >> off via power button still works with this change. It's desirable to test power >> off at least two times to increase a chance of non-BSP CPU being used. > > With an AMD Athlon(tm) 64 X2 Dual Core Processor 4600+ (2542.15-MHz K8-class CPU) > the first few shutdowns were successful, but on the fourth try pressing the > power button only lead to: > > Apr 18 12:52:42 kendra kernel: acpi: suspend request ignored (not ready yet) > Apr 18 12:52:42 kendra kernel: acpi: request to enter state S5 failed (err 6) > Apr 18 12:52:43 kendra kernel: acpi: suspend request ignored (not ready yet) > Apr 18 12:52:43 kendra kernel: acpi: request to enter state S5 failed (err 6) > Apr 18 12:52:43 kendra kernel: acpi: suspend request ignored (not ready yet) > Apr 18 12:52:43 kendra kernel: acpi: request to enter state S5 failed (err 6) > [...] Yes, I think the case for S5 should probably come before acpi_sleep_disable(). -- Nate