Date: Sat, 30 Aug 2003 02:41:45 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20030830023923.Q811@odysseus.silby.com> In-Reply-To: <200308291912.h7TJCIfP047192@repoman.freebsd.org> References: <200308291912.h7TJCIfP047192@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 29 Aug 2003, Robert Watson wrote: > rwatson 2003/08/29 12:12:18 PDT > > FreeBSD src repository > > Modified files: > sys/net if_ethersubr.c > Log: > Introduce error checking for calls to M_PREPEND(): > > ether_output() when prepending netatalk AFA_PHASE2 llc headers (TRYWAIT). > ether_output() when prepending ethernet header to a frame (DONTWAIT). I may have mentioned this before, but it would really useful to have code which we could easily paste where needed that would do a "fail once per caller". This would be much more useful than random failures in detecting callers that don't check return values because it would ensure that each case was hit, whereas random failures only offer a statistical chance that it will happen after a sufficiently long period of time. I'm envisioning something which keeps a linked list of caller addresses... horribly inefficient, but useable enough to be hidden being a FAILURE_STRESS_TEST option. Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030830023923.Q811>