Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 09 Jan 2002 12:19:36 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        sheldonh@FreeBSD.org
Cc:        freebsd-bugs@FreeBSD.org, Anders Nor Berle <debolaz@debolaz.com>
Subject:   Re: kern/33124: kthread_create doesnt mark kthreads as kthreads.
Message-ID:  <XFMail.020109121936.jhb@FreeBSD.org>
In-Reply-To: <200201091433.g09EXdc01274@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 09-Jan-02 sheldonh@FreeBSD.org wrote:
> Synopsis: kthread_create doesnt mark kthreads as kthreads.
> 
> Responsible-Changed-From-To: freebsd-bugs->jhb
> Responsible-Changed-By: sheldonh
> Responsible-Changed-When: Wed Jan 9 06:30:03 PST 2002
> Responsible-Changed-Why: 
> John has already made a similar change in HEAD, but the change doesn't
> seem to have been merged onto RELENG_4.
> 
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33124

This is actually kind of bogus.  Nobody uses this flag except aio, and aio just
sets the flag, no code actually checks it.  P_KTHREAD is a new flag in -current
used in a few places.  Unless the submitter has code that actually checks
P_KTHREADP and needs it set for some reason, I would rather see the flag killed.
One thing that might be nice to MFC is changing aio to use kthread_create
rather than using its own home-rolled version.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020109121936.jhb>