From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:12:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE00716AE16; Thu, 1 Jun 2006 10:12:31 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 697AB43D48; Thu, 1 Jun 2006 10:12:31 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (net-ix.gw.ai.net [205.134.160.6] (may be forged)) (authenticated bits=0) by pittgoth.com (8.13.4/8.13.4) with ESMTP id k51BLuqf061071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 1 Jun 2006 07:21:57 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Thu, 1 Jun 2006 06:12:22 -0400 From: Tom Rhodes To: Alexey Dokuchaev Message-Id: <20060601061222.52aaed2d.trhodes@FreeBSD.org> In-Reply-To: <20060601100126.GA43737@FreeBSD.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: maxim@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, grog@FreeBSD.org, ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:12:39 -0000 On Thu, 1 Jun 2006 10:01:27 +0000 Alexey Dokuchaev wrote: > On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > > maxim 2006-05-31 13:15:29 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/ufs/ufs ufs_vnops.c > > > > Log: > > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > > for file types other than VREG, VDIR and shared memory objects. > > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > > > Revision Changes Path > > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > > > Is this worth a man page update? > > > > Undoubtedly. Does the attached look like enough? I'm not sure if we > > want to add a STANDARDS section for this when it's valid behaviour. > > > > Ceri > > -- > > That must be wonderful! I don't understand it at all. > > -- Moliere > > > Index: src/lib/libc/sys/truncate.2 > > =================================================================== > > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v > > retrieving revision 1.17 > > diff -u -r1.17 truncate.2 > > --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 > > +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 > > @@ -32,7 +32,7 @@ > > .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 > > .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $ > > .\" > > -.Dd June 4, 1993 > > +.Dd June 1, 2006 > > .Dt TRUNCATE 2 > > .Os > > .Sh NAME > > @@ -69,6 +69,10 @@ > > the file must be open for writing. > > .Sh RETURN VALUES > > .Rv -std > > +If the file to be modified is not a directory or > > +a regular file, the > > +.Fn truncate > > +call will return the value 0. > > Doesn't "value of 0" sound better? I like "zero" - we should see what core thinks first though. -- Tom Rhodes