Date: Wed, 2 Jul 2008 21:16:05 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Rong-En Fan <rafan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/lynx Makefile pkg-plist Message-ID: <20080702211605.GA50200@FreeBSD.org> In-Reply-To: <200807021457.m62EvudQ046920@repoman.freebsd.org> References: <200807021457.m62EvudQ046920@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 02, 2008 at 02:57:56PM +0000, Rong-En Fan wrote: > rafan 2008-07-02 14:57:56 UTC > > FreeBSD ports repository > > Modified files: > www/lynx Makefile pkg-plist > Log: > - Use ncursesw if available > - Use gzip for documents > - OPTIONS'ify > - Bump PORTREVISION I have a couple of questions: - Is CONFIGURE_TARGET really necessary here? Is yes, could you elaborate on why whould it be? - Exatra parameter --enable-nested-tables was added to CONFIGURE_ARGS, but commit log does not mention it. What changes does it bring? - In OPTIONS, "Colors support" does not look very descriptive to me - Again in OPTIONS, "IPV6 support" should probably be speeled as IPv6 - OPTIONS are badly indented - .if defined(WITH_IPV6) && ! defined(NO_INET6) -- superfluous space after ! - ENABLE_DEFAULT_COLORS should probably be dropped altogether (with corresponding UPDARING note): we should not encourage non-standard knobs (i.e. not starting with WITH/WITHOUT) in most cases This is just what cathes the eye, it's not thorough review. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080702211605.GA50200>